Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

status: Pass correct remote name when verifying #3131

Merged
merged 2 commits into from
Jan 5, 2024

Conversation

cgwalters
Copy link
Member

The default ostree admin status tries to do signature verification, but doesn't error out if that fails.

However, an extremely longstanding bug here is that we passed the "osname" aka stateroot instead of the remote name. This happens to work for e.g. Fedora Silverblue today, where they are the same. It doesn't work on FCOS (remote = fedora, stateroot = fedora-coreos).

The default `ostree admin status` tries to do signature
verification, but doesn't error out if that fails.

However, an extremely longstanding bug here is that we passed
the "osname" aka stateroot instead of the remote name.  This
happens to work for e.g. Fedora Silverblue today, where they
are the same.  It doesn't work on FCOS (remote = fedora, stateroot = fedora-coreos).
Since it's really expensive in some cases.
Copy link
Collaborator

@ericcurtin ericcurtin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, gonna run a test on this branch first, because why not.

@ericcurtin
Copy link
Collaborator

Tested, also superfast:

time LD_LIBRARY_PATH=.libs ./.libs/ostree admin status
* fedora b85477d99c978596689e50e47e3a571816c0a93ea35b994e1c84a98cc3318695.0
    Version: 38.20240104.0
    Unlocked: development
    origin: <unknown origin type>
  fedora 2f0b019864dbc2ff2be71f64f80b64a2499c612b41d6c6f738658495cd76c9e9.0 (rollback)
    Version: 38.20240104.0
    origin: <unknown origin type>

real	0m0.016s
user	0m0.006s
sys	0m0.010s

@ericcurtin ericcurtin merged commit ac8638f into ostreedev:main Jan 5, 2024
23 of 24 checks passed
@ericcurtin
Copy link
Collaborator

Sorry this failed one of the builds because of ifdef differences, gonna fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants