Misc c99 style 2 #2993
Merged
Misc c99 style 2 #2993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just keeping up momentum.
ericcurtin
reviewed
Aug 18, 2023
| @@ -293,37 +290,33 @@ process_many_checkouts (OstreeRepo *repo, const char *target, GCancellable *canc | |||
|
|
|||
| /* Read the null byte */ | |||
| (void)g_data_input_stream_read_byte (datastream, cancellable, NULL); | |||
| g_free (subpath); | |||
There was a problem hiding this comment.
A good example of why C99 is better, declare when you need helps prevent silliness like this.
ericcurtin
reviewed
Aug 18, 2023
|
|
||
| *bytes_read = inbuf_size - self->lstream.avail_in; | ||
| *bytes_written = outbuf_size - self->lstream.avail_out; | ||
|
|
||
| out: | ||
| return _ostree_lzma_return (res, error); | ||
| return G_CONVERTER_CONVERTED; |
There was a problem hiding this comment.
This should be _ostree_lzma_return (res, error), it wasn't guaranteed to be G_CONVERTER_CONVERTED before, as we only check for certain values before this, maybe the goto makes sense here tbh... Duplicating the _ostree_lzma_return is ok too though...
Just keeping up momentum.
cgwalters
force-pushed
the
misc-c99-style-2
branch
from
c85daab
to
22b4778
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lzma: Port to C99 style
Just keeping up momentum.
checkout: Port to C99 style
Just keeping up momentum.