Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misc c99 style #2991

Merged
merged 2 commits into from
Aug 17, 2023
Merged

Misc c99 style #2991

merged 2 commits into from
Aug 17, 2023

Conversation

cgwalters
Copy link
Member

admin: Port to c99 style

  • Drop goto out
  • Use declare-and-initialize

remote-add: Port to c99 style

  • Drop goto out
  • Use declare-and-initialize

@cgwalters
admin: Port to c99 style
9036c96 
- Drop `goto out`
- Use declare-and-initialize
@cgwalters
remote-add: Port to c99 style
9f39f78 
- Drop `goto out`
- Use declare-and-initialize
ericcurtin
ericcurtin approved these changes Aug 17, 2023
View reviewed changes
Copy link
Collaborator

@ericcurtin ericcurtin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I find the new style better to read and the old code did seem to use goto's just for the sake of it

@ericcurtin ericcurtin merged commit 722fc2d into ostreedev:main Aug 17, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericcurtin ericcurtin ericcurtin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cgwalters @ericcurtin