prepare-root: On a non-A/B androidboot system, boot system slot a #2975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericcurtin
force-pushed
the
androidboot-single-slot-mode
branch
from
42b0915
to
d1fbdb4
Compare
ericcurtin
force-pushed
the
androidboot-single-slot-mode
branch
from
d1fbdb4
to
525e143
Compare
Our commit messages include a "topic prefix" usually unless they're system wide changes. In this case something like (also slightly condensed)
|
cgwalters
requested changes
Aug 14, 2023
ericcurtin
force-pushed
the
androidboot-single-slot-mode
branch
from
525e143
to
0f0f0a9
Compare
ericcurtin
force-pushed
the
androidboot-single-slot-mode
branch
3 times, most recently
from
bd0e4f4
to
ba42ea0
Compare
ericcurtin
changed the title
cgwalters
reviewed
Aug 22, 2023
ericcurtin
force-pushed
the
androidboot-single-slot-mode
branch
from
ba42ea0
to
c8020a4
Compare
Sometimes android bootloaders boot in a nonab way: https://source.android.com/docs/core/ota/nonab In this case, "androidboot." kargs are present but not "androidboot.slot_suffix" specifically. In this case, rather than getting stuck in a partially booted environment, boot system slot a.
Used strspn based on feedback from similar function.
ericcurtin
force-pushed
the
androidboot-single-slot-mode
branch
from
c8020a4
to
6e9e50d
Compare
|
Hitting flakes in the CI I think |
|
/retest |
|
@ericcurtin: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/test images |
cgwalters
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes android bootloaders boot in a nonab way:
https://source.android.com/docs/core/ota/nonab
In this case, "androidboot." kargs are present but not "androidboot.slot_suffix" specifically.
In this case, rather than getting stuck in a partially booted environment, boot system slot a.