Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement ed255519 using openssl too #2922

Merged
merged 4 commits into from
Jul 7, 2023
Merged

Implement ed255519 using openssl too #2922

merged 4 commits into from
Jul 7, 2023

Commits on Jul 7, 2023

  1. sign-ed25519: Drop some uses of libsodium 

    This adds some defines for ed25519 key sizes and drops uses
of the libsodium defines for these, as well as replacing sodium_bin2hex
use with ot_bin2hex. Some code that wes optionally built before are now
always built.

The goal for this is to support both libsodium and openssl.

Also fixes return value of _load_pk_from_stream(). It used
to always return FALSE.
    @alexlarsson
    alexlarsson committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    501575c View commit details
    Browse the repository at this point in the history

  2. sign-ed25519: Implement sign and verify using openssl 

    libsodium is used if configured to keep the old behaviour, but if
it is not enabled, and openssl is used, then ed25519 is now supported.
    @alexlarsson
    alexlarsson committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    7b85adf View commit details
    Browse the repository at this point in the history

  3. CI: Enable --with-crypto=openssl on debian testing to test openssl si… 

    …gnatures
    @alexlarsson
    alexlarsson committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    474c2b1 View commit details
    Browse the repository at this point in the history

  4. libotutil: Link to crypto libs 

    The checksum utils uses the crypto lib, but we're not explicitly linking
to it. I think this is why the CI got this error when using openssl
on debian, during ostree binary linking:

/usr/bin/ld: ./.libs/libotutil.a(libotutil_la-ot-checksum-utils.o): undefined reference to symbol 'EVP_DigestInit_ex@@OPENSSL_3.0.0'
/usr/bin/ld: /lib/x86_64-linux-gnu/libcrypto.so.3: error adding symbols: DSO missing from command line
collect2: error: ld returned 1 exit status
    @alexlarsson
    alexlarsson committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    744967a View commit details
    Browse the repository at this point in the history