tests: two fixes #637
Merged
tests: two fixes #637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because we were only doing bare-user checkouts in the test suite (and not trying to physically materialize the xattrs) and because ostree today doesn't validate xattrs, this problem was silently ignored. But I was looking at changing the tests to do a checkout, and this caused confusing failures. Add the missing trailing `NUL`. Also while we're here, split the xattr function in two; one which returns the Rust-native value and a wrapper which converts to GVariant. This will be useful later.
This helped me debug a recent problem.
cgwalters
changed the title
jeckersb
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixture: Add missing trailing NUL in security.selinux xattr
Because we were only doing bare-user checkouts in the test
suite (and not trying to physically materialize the xattrs)
and because ostree today doesn't validate xattrs, this
problem was silently ignored. But I was looking at
changing the tests to do a checkout, and this caused confusing
failures.
Add the missing trailing
NUL. Also while we're here,split the xattr function in two; one which returns the
Rust-native value and a wrapper which converts to GVariant.
This will be useful later.
tests: Add some error context
This helped me debug a recent problem.