lib: use pkg-config feature for zstd #628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't want to default to using vendored C sources. Signed-off-by: Colin Walters <[email protected]>
jeckersb
added a commit
to jeckersb/bootc
that referenced
this pull request
May 22, 2024
(For Fedora - https://src.fedoraproject.org/rpms/bootc/pull-request/3) Required after ostreedev/ostree-rs-ext#628 Signed-off-by: John Eckersberg <[email protected]>
|
Hm need to update deps to include libzstd-devel for this. Added: |
|
|
lukewarmtemp
pushed a commit
to lukewarmtemp/bootc
that referenced
this pull request
May 27, 2024
(For Fedora - https://src.fedoraproject.org/rpms/bootc/pull-request/3) Required after ostreedev/ostree-rs-ext#628 Signed-off-by: John Eckersberg <[email protected]>
jmarrero
added a commit
to jmarrero/rpm-ostree
that referenced
this pull request
Aug 9, 2024
After the initial changes to ostree-ext introducing support for zstd:chunked, which can be found in this pull request: ostreedev/ostree-rs-ext#615, an additional PR modified the dependency on zstd during build time to use pkg-config. You can review these changes in the pull request: ostreedev/ostree-rs-ext#628. These updates also required modifications to bootc, detailed in this pull request: containers/bootc#586. This commit mirrors those changes in rpm-ostree. With these changes, it will be possible to build RPMs on systems that do not have zstd-devel pre-installed in the build root.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't want to default to using vendored C sources.