Add previous container image state #499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukewarmtemp
force-pushed
the
add-previous-state-manifest
branch
from
3ad8c0c
to
4bb8261
Compare
lukewarmtemp
force-pushed
the
add-previous-state-manifest
branch
3 times, most recently
from
3f126b9
to
fd4e558
Compare
cgwalters
reviewed
Jul 19, 2023
lukewarmtemp
force-pushed
the
add-previous-state-manifest
branch
2 times, most recently
from
24aacc4
to
caca293
Compare
cgwalters
reviewed
Jul 26, 2023
lukewarmtemp
force-pushed
the
add-previous-state-manifest
branch
from
a6d0a04
to
b870c18
Compare
|
@lukewarmtemp https://github.com/ostreedev/ostree-rs-ext/actions/runs/5682576042/job/15401438954?pr=499 looks like you need to run cargo fmt on |
cgwalters
reviewed
Jul 27, 2023
This commit is a prerequisite to issue #4176 in the rpm-ostree repo, implementing the `rpm-ostree upgrade --check` feature for ostree native containers. A previous_state `LayeredImageState` object is added to the `PreparedImport` object, used to store the previous container state when importing a container image. A `export_as_string()` function is added to the `ManifestDiff` object to allow rpm-ostree to print the manifest diff on the client side. The code is exactly the same as the existing `print()` function for `ManifestDiff`, except it returns a string instead of printing out the diff in the terminal.
lukewarmtemp
force-pushed
the
add-previous-state-manifest
branch
from
5d98b69
to
c7ae1a0
Compare
cgwalters
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisite for the
rpm-ostree upgrade --checkissue: coreos/rpm-ostree#4486Implemented:
LayeredImageStateobject added to thePreparedImportobjectexport_as_string()function is added to theManifestDiffobjectNote: The
previous_statemember of the struct is not actually used in the rpm-ostree issue stated above. Only theexport_as_string()is used. However, the changes may see use in the future and can probably be left in.See commit message for more details.