-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WebRTC: Add error tips when coverting HEVC to RTC. #3425
base: develop
Are you sure you want to change the base?
WebRTC: Add error tips when coverting HEVC to RTC. #3425
Conversation
Please hold on this PR, because it depends on #3392 |
Wow, so fucking awesome HEVC over Webrtc, crazy guys! |
This PR is just adding some error logs to notice user that HEVC over WebRTC is not supported. 😃 However, we found that Safari supports HEVC over WebRTC, so we will try to do that in another PR. If one day, Chrome supports HEVC over WebRTC, the HEVC should be very easy to use for both live streaming and WebRTC. |
@@ -997,6 +990,11 @@ srs_error_t SrsRtcFromRtmpBridge::on_video(SrsSharedPtrMessage* msg) | |||
return err; | |||
} | |||
|
|||
// WebRTC NOT support HEVC, RTMP NOT support VP8/VP9. | |||
if (format->vcodec->id != SrsVideoCodecIdAVC && format->vcodec->id != SrsVideoCodecIdAV1) { | |||
return srs_error_new(ERROR_RTC_CODEC_ERROR, "WebRTC not support %s", srs_video_codec_id2str(format->vcodec->id).c_str()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If an error is returned here, it will cause the log to output continuously.
TRANS_BY_GPT3
c056094
to
2ac9eb8
Compare
0bb9637
to
2e211f6
Compare
When you push hevc stream by opening
rtmp_to_rtc on
, we'll return error tips forWebRTC not support HEVC
.Publish RTMP HEVC
Publish SRT HEVC
Publish GB HEVC