Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed github logo on member page to be a generic git icon #308

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Changed github logo on member page to be a generic git icon #308

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5e794cb
Changed github logo on member page to be a generic git icon
csrs Oct 12, 2019
f4c7bde
merging
csrs Nov 11, 2019
4bdf5a1
Changed wording of text input
csrs Nov 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/components/components/member/member.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import {
Calendar,
Check,
Feather,
GitHub,
GitCommit,
Inbox,
Link,
Users,
Expand Down Expand Up @@ -392,9 +392,9 @@ class Member extends React.PureComponent {

const github = isEditing ? (
<div className="member__text-field--wrapper-with-icon">
<GitHub className="member__icon" />
<GitCommit className="member__icon" />
<TextInput
label="Github Url"
label="Github/Gitlab/Bitbucket Url"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it would be better if we wrote something like "Git server url (for example Github, Gitlab or Bitbucket)" ?

@bacharakis thoughts?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll update it to use that language... it's more specific

name="githubUrl"
onChange={this.handleChange}
value={snapshot.githubUrl}
Expand All @@ -404,7 +404,7 @@ class Member extends React.PureComponent {
) : (
snapshot.githubUrl && (
<a href={snapshot.githubUrl} target="_blank" rel="noopener noreferrer">
<GitHub className="member__icon" />
<GitCommit className="member__icon" />
<span className="member__link-content">{snapshot.githubUrl}</span>
</a>
)
Expand Down