🌱 silence gocritic warnings by specifying enabled checks #4546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disable all the checks, then turn the ones we want on one-by-one. This list matches what we already had in the config, plus the checks which are enabled by default. The end result is the same list of linters, but we silence the warnings reported in ossf#4439. Signed-off-by: Spencer Schrock <[email protected]>
Signed-off-by: Spencer Schrock <[email protected]>
spencerschrock
requested review from
justaugustus and
raghavkaul
and removed request for
a team
spencerschrock
temporarily deployed
to
integration-test
GitHub Actions
Inactive
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4546 +/- ##
==========================================
+ Coverage 66.80% 68.36% +1.56%
==========================================
Files 230 248 +18
Lines 16602 18762 +2160
==========================================
+ Hits 11091 12827 +1736
- Misses 4808 5084 +276
- Partials 703 851 +148 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
linter config
What is the current behavior?
Some checks run by default, some run because we enable them.
What is the new behavior (if this is a feature change)?**
Disable all the checks, then turn the ones we want on one-by-one. This list matches what we already had in the config, plus the checks which are enabled by default. The end result is the same list of linters (confirmed with
GL_DEBUG=gocritic golangci-lint run --enable=gocriticbut we silence the warnings reported in #4439.Which issue(s) this PR fixes
Fixes #4439
Special notes for your reviewer
I also sorted the list, and one or two existing values moved around, if you look commit by commit it's easier to see the added default checks, and the sort.
Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the
release-note(In particular, describe what changes users might need to make in their
application as a result of this pull request.)