🌱 Add tests for probe output format #3841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Spencer Schrock <[email protected]>
the ability to pretty print will help write a test function Signed-off-by: Spencer Schrock <[email protected]>
Signed-off-by: Spencer Schrock <[email protected]>
Signed-off-by: Spencer Schrock <[email protected]>
Signed-off-by: Spencer Schrock <[email protected]>
Signed-off-by: Spencer Schrock <[email protected]>
spencerschrock
requested review from
naveensrinivasan and
raghavkaul
and removed request for
a team
spencerschrock
temporarily deployed
to
integration-test
GitHub Actions
Inactive
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3841 +/- ##
==========================================
- Coverage 75.55% 70.85% -4.70%
==========================================
Files 232 232
Lines 15784 15788 +4
==========================================
- Hits 11925 11187 -738
- Misses 3122 3914 +792
+ Partials 737 687 -50 |
naveensrinivasan
approved these changes
Feb 2, 2024
cpanato
approved these changes
Feb 4, 2024
spencerschrock
temporarily deployed
to
integration-test
GitHub Actions
Inactive
fhoeborn
pushed a commit
to fhoeborn/scorecard
that referenced
this pull request
Apr 1, 2024
* rename probe format file Signed-off-by: Spencer Schrock <[email protected]> * add option parameter to probe result output function the ability to pretty print will help write a test function Signed-off-by: Spencer Schrock <[email protected]> * add test func Signed-off-by: Spencer Schrock <[email protected]> * add docstring Signed-off-by: Spencer Schrock <[email protected]> * clarify test. add another finding Signed-off-by: Spencer Schrock <[email protected]> * force add the test file Signed-off-by: Spencer Schrock <[email protected]> --------- Signed-off-by: Spencer Schrock <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Add tests
What is the current behavior?
No tests
What is the new behavior (if this is a feature change)?**
Tests, and there's a config option added to the output function. This was primarily done to make the test files more readable, instead of having the JSON output be one long line.
Which issue(s) this PR fixes
Fixes #3110
Special notes for your reviewer
Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the
release-note(In particular, describe what changes users might need to make in their
application as a result of this pull request.)