Use a concrete struct while parsing JSON to reduce memory consumption. #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The npm package json can be very large. Using the
`map[string]interface{}` results in the entire json data structure being
deserialized. This costs a lot of memory and cpu time.
The feed parser only needs the "time" portion of the json data, so by
restricting the struct to that data we avoid a lot of overhead.
Testing shows memory peaks close to 70Mb with this fix, rather than the
512Mb+ previously.
oliverchang
approved these changes
Nov 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The npm package json can be very large. Using the
map[string]interface{}results in the entire json data structure beingdeserialized. This costs a lot of memory and cpu time.
The feed parser only needs the "time" portion of the json data, so by
restricting the struct to that data we avoid a lot of overhead.
Testing shows memory peaks close to 70Mb with this fix, rather than the
512Mb+ previously.
This helps mitigate issue #152