Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Included tests for internal/collector/source #310

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

nathannaveen
Copy link
Contributor

  • Included some tests for internal/collector/source

Signed-off-by: nathannaveen [email protected]

@nathannaveen
Copy link
Contributor Author

I couldn't complete the Get() tests because when mocking bqAPI it resulted in the files calling each other in a cycle. I also didn't complete the NewSource() tests because I can't mock bigquery.NewClient().

- Included some tests for internal/collector/source

Signed-off-by: nathannaveen <[email protected]>
@nathannaveen
Copy link
Contributor Author

@calebbrown A friendly ping!

internal/collector/depsdev/source_test.go Outdated Show resolved Hide resolved
internal/collector/depsdev/source_test.go Outdated Show resolved Hide resolved
internal/collector/depsdev/source_test.go Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants