This repository has been archived by the owner on Sep 8, 2021. It is now read-only.
Add automatic DNS creation using HAR #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a small bug where hostnames were not being detected when we used domains with more than 3 parts, like Azure's, the splitting was done but the handler would not identify the host properly. Using HAR the domain is <name>.<uuid>.<location>.aksapp.io which is 5 parts when splitted. I changed the rule so the host is not discarded.
I really don't know how it was working before
|
From @khaosdoctor : I created a |
|
Awesome! Thanks a lot! |
|
I forgot to update the docs with the newest information about the ingress, I'll open another PR to do so. Once this is closed |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'll split this PR into two parts, this part is only to add the ingress controller using HTTP Application Routing (HAR) and create a DNS name for the admin API.
Also, the Admin SVC is now closed to the public, made it ClusterIP. However, the proxy is still a LoadBalancer.
Next steps:
Add the admin server URL as default when using the capps bin (will look at how to do that)
Add ingress creation for all services created with run pointing to the proxy IP
Fixes #1