Refactor FossID config #9745
Merged
Refactor FossID config #9745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnonnenmacher
changed the title
namingProjectPattern with projectName
mnonnenmacher
commented
Jan 14, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9745 +/- ##
=========================================
Coverage 68.08% 68.08%
Complexity 1293 1293
=========================================
Files 249 249
Lines 8845 8845
Branches 923 923
=========================================
Hits 6022 6022
Misses 2434 2434
Partials 389 389
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
nnobelis
reviewed
Jan 15, 2025
mnonnenmacher
force-pushed
the
refactor-fossid-config
branch
from
357b58a to
1c7d785
Compare
|
@sschuberth Would be nice to get this into the release tomorrow, then all breaking FossID config changes would happen in a single release. |
Looks like |
Remove the functionality to define a pattern to determine the project name and instead make the project name configurable as a constant value, because in practice it turned out that the flexibility provided by the pattern is not required. If no `projectName` is configured, it is determined from the Git repository URL as before. This change requires adaptations in the "delete newly triggered scans if a package cannot be scanned" test, because it used mocking to make the removed `createProjectCode` function behave in a way it would not behave at runtime. Signed-off-by: Martin Nonnenmacher <[email protected]>
Add support for `projectName` as a built-in variable for the `namingScanPattern`. This allows to easily include the project name in the generated scan code. Signed-off-by: Martin Nonnenmacher <[email protected]>
Remove support for adding custom naming variables prefixed with `namingVariable`. Instead, custom values can be written directly into the `namingScanPattern`. Signed-off-by: Martin Nonnenmacher <[email protected]>
mnonnenmacher
force-pushed
the
refactor-fossid-config
branch
from
1c7d785 to
3e6de50
Compare
sschuberth
previously approved these changes
Jan 15, 2025
Replace the custom options to define URL mappings with a single comma-separated option `urlMappings`. This will simplify the migration to the new plugin API. Signed-off-by: Martin Nonnenmacher <[email protected]>
This allows handling the property like all other config properties for consistency and removes the need to store the plain `options` in the config class. Signed-off-by: Martin Nonnenmacher <[email protected]>
mnonnenmacher
force-pushed
the
refactor-fossid-config
branch
from
3e6de50 to
7c29ab3
Compare
sschuberth
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the FossID config to prepare for migrating scanners to the new plugin API. See the commit messages for details.