Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update exposed to v0.58.0 #9731

Merged
merged 1 commit into from
Jan 15, 2025
Merged

deps: update exposed to v0.58.0 #9731

merged 1 commit into from
Jan 15, 2025

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jan 13, 2025

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
org.jetbrains.exposed:exposed-json 0.57.0 -> 0.58.0 age adoption passing confidence
org.jetbrains.exposed:exposed-jdbc 0.57.0 -> 0.58.0 age adoption passing confidence
org.jetbrains.exposed:exposed-java-time 0.57.0 -> 0.58.0 age adoption passing confidence
org.jetbrains.exposed:exposed-dao 0.57.0 -> 0.58.0 age adoption passing confidence
org.jetbrains.exposed:exposed-core 0.57.0 -> 0.58.0 age adoption passing confidence

Release Notes

JetBrains/Exposed (org.jetbrains.exposed:exposed-json)

v0.58.0

Compare Source

What's Changed

Breaking changes:

  • fix: EXPOSED-662 SchemaUtils.listTables() returns empty list & closes db connection by @​joc-a in https://github.com/JetBrains/Exposed/pull/2331
    • SchemaUtils.listTables() returns only the tables from the current schema. The behaviour was returned to the 0.56.0 version.
    • To get tables from all the schemas the method SchemaUtils.listTablesInAllSchemas() could be used.

Features:

Infrastructure:

  • springFramework 6.2.1
  • log4j2 2.24.3
  • org.junit:junit-bom 5.11.4
  • org.jetbrains.dokka 2.0.0
  • springBoot 3.4.1
  • kotlinCoroutines 1.10.0
  • kotlinCoroutines 1.10.1
  • org.xerial:sqlite-jdbc from 3.47.2.0
  • org.jetbrains.kotlinx.binary-compatibility-validator 0.17.0
  • org.jetbrains.kotlinx:kotlinx-serialization-json 1.8.0

Docs:


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot requested a review from a team as a code owner January 13, 2025 13:46
@renovate renovate bot added the dependencies Pull requests that update a dependency file label Jan 13, 2025
@sschuberth sschuberth enabled auto-merge (rebase) January 13, 2025 13:50
sschuberth
sschuberth previously approved these changes Jan 13, 2025
@renovate renovate bot force-pushed the renovate/exposed branch from f24d696 to 6fb3d56 Compare January 13, 2025 13:52
@sschuberth sschuberth assigned sschuberth and unassigned sschuberth Jan 14, 2025
@sschuberth
Copy link
Member

@mnonnenmacher I have no idea how to deal with the createMissingTablesAndColumns() deprecation and the hint

    @Deprecated(
        "Execution of this function might lead to unpredictable state in the database if a failure occurs at any point. " +
            "To prevent this, please use `MigrationUtils.statementsRequiredForDatabaseMigration` with a third-party migration tool (e.g., Flyway).",
        ReplaceWith("MigrationUtils.statementsRequiredForDatabaseMigration"),
        DeprecationLevel.WARNING
    )
    fun createMissingTablesAndColumns(vararg tables: Table, inBatch: Boolean = false, withLogs: Boolean = true) {

Can you help?

@mnonnenmacher
Copy link
Member

@mnonnenmacher I have no idea how to deal with the createMissingTablesAndColumns() deprecation and the hint

    @Deprecated(
        "Execution of this function might lead to unpredictable state in the database if a failure occurs at any point. " +
            "To prevent this, please use `MigrationUtils.statementsRequiredForDatabaseMigration` with a third-party migration tool (e.g., Flyway).",
        ReplaceWith("MigrationUtils.statementsRequiredForDatabaseMigration"),
        DeprecationLevel.WARNING
    )
    fun createMissingTablesAndColumns(vararg tables: Table, inBatch: Boolean = false, withLogs: Boolean = true) {

Can you help?

Yes, but probably not today.

@mnonnenmacher mnonnenmacher self-assigned this Jan 14, 2025
The `createMissingTablesAndColumns` function was deprecated, ignore this
for now as finding a different solution requires more work.
@mnonnenmacher
Copy link
Member

@sschuberth I decided to just ignore the deprecation for now, I could not find a trivial alternative and don't have time to investigate further.

@@ -66,6 +66,7 @@
withDataBaseLock {
if (!tableExists(table.tableName)) {
checkDatabaseEncoding()
@Suppress("DEPRECATION")

Check warning

Code scanning / QDJVMC

Redundant diagnostic suppression Warning

Redundant suppression
@@ -125,6 +125,7 @@
withDataBaseLock {
if (!tableExists(tableName)) {
checkDatabaseEncoding()
@Suppress("DEPRECATION")

Check warning

Code scanning / QDJVMC

Redundant diagnostic suppression Warning

Redundant suppression
@@ -57,6 +57,7 @@
withDataBaseLock {
if (!tableExists(tableName)) {
checkDatabaseEncoding()
@Suppress("DEPRECATION")

Check warning

Code scanning / QDJVMC

Redundant diagnostic suppression Warning

Redundant suppression
@@ -59,6 +59,7 @@
withDataBaseLock {
if (!tableExists(tableName)) {
checkDatabaseEncoding()
@Suppress("DEPRECATION")

Check warning

Code scanning / QDJVMC

Redundant diagnostic suppression Warning

Redundant suppression
@@ -78,6 +78,7 @@
if (!tableExists(TABLE_NAME)) {
checkDatabaseEncoding()

@Suppress("DEPRECATION")

Check warning

Code scanning / QDJVMC

Redundant diagnostic suppression Warning

Redundant suppression
@@ -71,6 +71,7 @@
withDataBaseLock {
if (!tableExists(tableName)) {
checkDatabaseEncoding()
@Suppress("DEPRECATION")

Check warning

Code scanning / QDJVMC

Redundant diagnostic suppression Warning

Redundant suppression
@sschuberth sschuberth merged commit e20304b into main Jan 15, 2025
24 checks passed
@sschuberth sschuberth deleted the renovate/exposed branch January 15, 2025 16:09
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.08%. Comparing base (1b63f86) to head (acaba28).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #9731   +/-   ##
=========================================
  Coverage     68.08%   68.08%           
  Complexity     1293     1293           
=========================================
  Files           249      249           
  Lines          8845     8845           
  Branches        923      923           
=========================================
  Hits           6022     6022           
  Misses         2434     2434           
  Partials        389      389           
Flag Coverage Δ
funTest-docker 65.02% <ø> (ø)
funTest-non-docker 33.30% <ø> (ø)
test-ubuntu-24.04 35.91% <ø> (ø)
test-windows-2022 35.89% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants