Node package manager improvements #9426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Make more clear that these files host functions that are for any Node package manager, not just NPM specifically. Also rename the `NodePackageManager` enum to `NodePackageManagerType` to make room for another class that is more appropriate to use that name. Signed-off-by: Sebastian Schuberth <[email protected]>
Prepare for generalizing some code. Signed-off-by: Sebastian Schuberth <[email protected]>
Put code that is common to all Node package managers into an abstract base class to reduce code duplication and to ease upcoming changes. As some types are now exposed through the class hierarchy / constructor parameters, it is required to make them public. While at it, also perform some minor code alignments. Note that this reintroduction of a class hierarchy does not go against the idea of recently made changes to decouple the individual Node package manager implementations from each other: It is still the case that e.g. the PNPM implementation should not inherit from the NPM implementation. Signed-off-by: Sebastian Schuberth <[email protected]>
This avoids the need to pass the `managerName` as a parameter, and to have a top-level logger. Signed-off-by: Sebastian Schuberth <[email protected]>
Signed-off-by: Sebastian Schuberth <[email protected]>
sschuberth
force-pushed
the
create-proj-helper
branch
from
2f44c7c to
ab452ad
Compare
sschuberth
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9426 +/- ##
============================================
- Coverage 68.07% 68.07% -0.01%
+ Complexity 1291 1285 -6
============================================
Files 249 249
Lines 8837 8827 -10
Branches 918 918
============================================
- Hits 6016 6009 -7
+ Misses 2435 2432 -3
Partials 386 386
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mnonnenmacher
approved these changes
Jan 16, 2025
|
@fviernau agreed privately to proceed with this without his review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This centralizes project creation which will ease an upcoming change.