Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update link references of ownership from nexB to aboutcode-org #9052

Closed

Conversation

chinyeungli
Copy link
Contributor

No description provided.

@chinyeungli chinyeungli requested review from a team as code owners August 30, 2024 05:54
@sschuberth
Copy link
Member

Thanks for the contribution @chinyeungli. Could you please share a bit about the logic that this new separation follows? Like, why is https://github.com/nexB/scancode-toolit moved, but e.g. https://github.com/nexB/typecode_libmagic_from_sources not?

Also, the commit message title should follow Conventional Commits. In this case, I'd use the "docs: " type.

Copy link

codecov bot commented Aug 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.02%. Comparing base (cf72d14) to head (d0958e5).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #9052   +/-   ##
=========================================
  Coverage     68.02%   68.02%           
  Complexity     1158     1158           
=========================================
  Files           241      241           
  Lines          7691     7691           
  Branches        867      867           
=========================================
  Hits           5232     5232           
  Misses         2103     2103           
  Partials        356      356           
Flag Coverage Δ
funTest-docker 67.39% <ø> (ø)
funTest-non-docker 33.92% <ø> (ø)
test 37.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chinyeungli
Copy link
Contributor Author

@sschuberth Sorry for missing the type in the commit. We are moving all the public repositories from nexB to aboutcode-org. The repository 'typecode_libmagic_from_sources' has now been migrated under aboutcode-org. (The repository, typecode_libmagic_from_sources, simply has not been migrated at the time of your check.)

@sschuberth
Copy link
Member

Sorry for missing the type in the commit.

To fix this, you actually need to amend you existing commit, not add new ones. Similarly, we don't allow merge commits as part of PRs. If you want to catch-up with latest main, please rebase force force-push instead.

So all-in-all, simply squash all your 3 commits into one commit that keeps only the title from the second commit. The body of that commit should contain this explanation of yours.

@chinyeungli
Copy link
Contributor Author

chinyeungli commented Aug 30, 2024

Perhaps it's easier to create a new PR.
#9053

@chinyeungli chinyeungli deleted the update_new_owner_refs branch August 30, 2024 07:29
@sschuberth
Copy link
Member

Perhaps it's easier to create a new PR.

Actually, no need for that. Just continue force-pushing to the PR's branch until the history is right 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants