-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update link references of ownership from nexB to aboutcode-org #9052
Update link references of ownership from nexB to aboutcode-org #9052
Conversation
Signed-off-by: Chin Yeung Li <[email protected]>
Thanks for the contribution @chinyeungli. Could you please share a bit about the logic that this new separation follows? Like, why is https://github.com/nexB/scancode-toolit moved, but e.g. https://github.com/nexB/typecode_libmagic_from_sources not? Also, the commit message title should follow Conventional Commits. In this case, I'd use the "docs: " type. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9052 +/- ##
=========================================
Coverage 68.02% 68.02%
Complexity 1158 1158
=========================================
Files 241 241
Lines 7691 7691
Branches 867 867
=========================================
Hits 5232 5232
Misses 2103 2103
Partials 356 356
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Chin Yeung Li <[email protected]>
…org/ort into update_new_owner_refs
@sschuberth Sorry for missing the type in the commit. We are moving all the public repositories from nexB to aboutcode-org. The repository 'typecode_libmagic_from_sources' has now been migrated under aboutcode-org. (The repository, typecode_libmagic_from_sources, simply has not been migrated at the time of your check.) |
To fix this, you actually need to amend you existing commit, not add new ones. Similarly, we don't allow merge commits as part of PRs. If you want to catch-up with latest So all-in-all, simply squash all your 3 commits into one commit that keeps only the title from the second commit. The body of that commit should contain this explanation of yours. |
Perhaps it's easier to create a new PR. |
Actually, no need for that. Just continue force-pushing to the PR's branch until the history is right 😉 |
No description provided.