Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(github): Do not use variables as part of attestation subject paths #8841

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

sschuberth
Copy link
Member

Work around another restriction of the build attestation action, see 1.

Work around another restriction of the build attestation action, see
[1].

[1]: actions/attest-build-provenance#146

Signed-off-by: Sebastian Schuberth <[email protected]>
@sschuberth sschuberth requested a review from a team as a code owner July 4, 2024 08:00
Copy link

codecov bot commented Jul 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.79%. Comparing base (2c0dc49) to head (f00ebe4).

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #8841   +/-   ##
=========================================
  Coverage     67.79%   67.79%           
  Complexity     1164     1164           
=========================================
  Files           243      243           
  Lines          7711     7711           
  Branches        861      861           
=========================================
  Hits           5228     5228           
  Misses         2127     2127           
  Partials        356      356           
Flag Coverage Δ
funTest-docker 66.84% <ø> (ø)
funTest-non-docker 33.96% <ø> (ø)
test 38.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sschuberth sschuberth merged commit 3f8f078 into main Jul 4, 2024
20 checks passed
@sschuberth sschuberth deleted the attest-no-env-var branch July 4, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants