Generalize GradleDependencyGraphBuilder #3877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oheger-bosch
force-pushed
the
oheger-bosch/analyzer/generalize_gradle_dependency_graph_builder
branch
2 times, most recently
from
3ef0916 to
36827f4
Compare
mnonnenmacher
requested changes
Apr 14, 2021
analyzer/src/main/kotlin/managers/utils/DependencyGraphBuilder.kt
Outdated
Show resolved
Hide resolved
analyzer/src/main/kotlin/managers/utils/DependencyGraphBuilder.kt
Outdated
Show resolved
Hide resolved
analyzer/src/main/kotlin/managers/utils/DependencyGraphBuilder.kt
Outdated
Show resolved
Hide resolved
analyzer/src/main/kotlin/managers/utils/DependencyGraphBuilder.kt
Outdated
Show resolved
Hide resolved
oheger-bosch
force-pushed
the
oheger-bosch/analyzer/generalize_gradle_dependency_graph_builder
branch
from
36827f4 to
3a0c647
Compare
sschuberth
reviewed
Apr 14, 2021
analyzer/src/main/kotlin/managers/utils/DependencyGraphBuilder.kt
Outdated
Show resolved
Hide resolved
analyzer/src/main/kotlin/managers/utils/DependencyGraphBuilder.kt
Outdated
Show resolved
Hide resolved
This interface plays a central role to generalize the GradleDependencyBuilder class to support other package managers as well. The idea is that each package manager can have its own, internal representation of a dependency. A DependencyHandler allows extracting information from such a representation, so that it can be processed by a generic builder, which does not need to have knowledge about the internals of a specific package manager implementation. Signed-off-by: Oliver Heger <[email protected]>
This class is a generalized variant of GradleDependencyGraphBuilder that can deal with arbitrary dependency models for which a DependencyHandler is available. In future, it is going to replace GradleDependencyGraphBuilder and be used for other package managers as well. Signed-off-by: Oliver Heger <[email protected]>
This is a prerequisite to use the new generic DependencyGraphBuilder class with the Gradle package manager. Signed-off-by: Oliver Heger <[email protected]>
Rework the test class for GradleDependencyGraphBuilder to operate on a generic DependencyGraphBuilder configured with a GradleDependencyHandler. This demonstrates that the Gradle-specific functionality has been correctly generalized. Rename the test class accordingly and move it to the managers package. Signed-off-by: Oliver Heger <[email protected]>
Replace GradleDependencyGraphBuilder by a combination of DependencyGraphBuilder and GradleDependencyHandler. The Gradle-specific implementation is going to be removed. Signed-off-by: Oliver Heger <[email protected]>
The class has been fully replaced by DependencyGraphBuilder. Signed-off-by: Oliver Heger <[email protected]>
oheger-bosch
force-pushed
the
oheger-bosch/analyzer/generalize_gradle_dependency_graph_builder
branch
from
3a0c647 to
836610b
Compare
sschuberth
approved these changes
Apr 15, 2021
mnonnenmacher
approved these changes
Apr 15, 2021
sschuberth
deleted the
oheger-bosch/analyzer/generalize_gradle_dependency_graph_builder
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a preparation to support the optimized dependency graph format for other package managers than Gradle (see #3825).
The specific
GradleDependencyGraphBuilderclass is replaced by a generic implementation, which can operate on different representations of dependencies. The information required to build up the dependency graph is obtained from the package manager-specific dependencies using aDependencyHandler.