test: Improve analysis of multiple definition files #10176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
fviernau
force-pushed
the
pnpm-test-improvement
branch
3 times, most recently
from
c09119c to
4bf5c63
Compare
sschuberth
reviewed
Apr 15, 2025
fviernau
force-pushed
the
pnpm-test-improvement
branch
3 times, most recently
from
a6a3659 to
ba0c59b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10176 +/- ##
=========================================
Coverage 69.62% 69.62%
- Complexity 1460 1461 +1
=========================================
Files 271 271
Lines 9747 9747
Branches 1031 1031
=========================================
Hits 6786 6786
Misses 2506 2506
Partials 455 455
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sschuberth
reviewed
Apr 15, 2025
| @@ -54,7 +54,7 @@ class YarnFunTest : StringSpec({ | |||
| val definitionFile = getAssetFile("projects/synthetic/yarn/workspaces/package.json") | |||
| val expectedResultFile = getAssetFile("projects/synthetic/yarn/workspaces-expected-output.yml") | |||
|
|
|||
| val result = YarnFactory.create().collateMultipleProjects(definitionFile).withResolvedScopes() | |||
| val result = analyze(definitionFile.parentFile, packageManagers = setOf(YarnFactory())).getAnalyzerResult() | |||
There was a problem hiding this comment.
There are more places in the code base that call the combination of create() / collateMultipleProjects() / withResolvedScopes() (e.g. Yarn2FunTest, TychoFunTest). Can we make use of the function there as well?
The test cares only about the analyzer result. So, use only that as expected result instead of the entire `OrtResult`. Signed-off-by: Frank Viernau <[email protected]>
fviernau
force-pushed
the
pnpm-test-improvement
branch
from
ba0c59b to
953c6e6
Compare
fviernau
changed the title
fviernau
force-pushed
the
pnpm-test-improvement
branch
from
953c6e6 to
96555a1
Compare
sschuberth
previously approved these changes
Apr 15, 2025
fviernau
force-pushed
the
pnpm-test-improvement
branch
from
96555a1 to
3e3883e
Compare
sschuberth
previously approved these changes
Apr 16, 2025
fviernau
force-pushed
the
pnpm-test-improvement
branch
from
3e3883e to
c76aec0
Compare
|
The recent change for |
Prepare for an upcoming change. Signed-off-by: Frank Viernau <[email protected]>
Remove the assumption how the mapping of the definitions files is made to make the test more resilient to code changes and to also make it cover the mapping of the definition files. Signed-off-by: Frank Viernau <[email protected]>
Signed-off-by: Frank Viernau <[email protected]>
fviernau
force-pushed
the
pnpm-test-improvement
branch
from
c76aec0 to
e72ae9c
Compare
I ended up making it an additional parameter. |
sschuberth
approved these changes
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits.