fix(model): Always use lowercase for serialized hash values

Ensure `OrtResult`s remain identical if only the "case" of a hash value changed, which also makes the functional tests tolerate that. Signed-off-by: Frank Viernau <[email protected]>
oss-review-toolkit · Feb 2, 2024 · cf5d3c3 · cf5d3c3
1 parent 4661582
commit cf5d3c3
Showing 1 changed file with 8 additions and 0 deletions.
diff --git a/model/src/main/kotlin/Hash.kt b/model/src/main/kotlin/Hash.kt
@@ -19,6 +19,9 @@
 
 package org.ossreviewtoolkit.model
 
+import com.fasterxml.jackson.databind.annotation.JsonSerialize
+import com.fasterxml.jackson.databind.util.StdConverter
+
 import java.io.File
 import java.util.Base64
 
@@ -32,6 +35,7 @@ data class Hash(
     /**
      * The value calculated using the hash algorithm.
      */
+    @JsonSerialize(converter = StringLowercaseConverter::class)
     val value: String,
 
     /**
@@ -96,3 +100,7 @@ data class Hash(
      */
     fun verify(hash: Hash): Boolean = algorithm == hash.algorithm && value.equals(hash.value, ignoreCase = true)
 }
+
+private class StringLowercaseConverter : StdConverter<String, String>() {
+    override fun convert(value: String): String = value.lowercase()
+}