feat(Carthage)!: Use the definition file path as fallback project name

If the project name cannot be determined from the VCS, use the path of
the definition file relative to the analysis root as fallback project
name. This reduces the risk of identifier conflicts if there are
Carthage projects in different directories with the same name.

Signed-off-by: Martin Nonnenmacher <[email protected]>

analyzer/src/main/kotlin/managers/Carthage.kt

@@ -69,7 +69,7 @@ class Carthage(
         // Transitive dependencies are only supported if the dependency itself uses Carthage.
         // See: https://github.com/Carthage/Carthage#nested-dependencies
         val workingDir = definitionFile.parentFile
-        val projectInfo = getProjectInfoFromVcs(workingDir)
+        val projectInfo = getProjectInfoFromVcs(definitionFile)
 
         return listOf(
             ProjectAnalyzerResult(
@@ -96,16 +96,16 @@ class Carthage(
     /**
      * As the "Carthage.resolved" file does not provide any project information, trying to retrieve some from VCS.
      */
-    private fun getProjectInfoFromVcs(workingDir: File): ProjectInfo {
-        val workingTree = VersionControlSystem.forDirectory(workingDir)
+    private fun getProjectInfoFromVcs(definitionFile: File): ProjectInfo {
+        val workingTree = VersionControlSystem.forDirectory(definitionFile.parentFile)
         val vcsInfo = workingTree?.getInfo().orEmpty()
         val normalizedVcsUrl = normalizeVcsUrl(vcsInfo.url)
         val vcsHost = VcsHost.fromUrl(normalizedVcsUrl)
 
         return ProjectInfo(
             namespace = vcsHost?.getUserOrOrganization(normalizedVcsUrl),
             projectName = vcsHost?.getProject(normalizedVcsUrl)
-                ?: workingDir.relativeTo(analysisRoot).invariantSeparatorsPath,
+                ?: getFallbackProjectName(analysisRoot, definitionFile),
             revision = vcsInfo.revision
         )
     }