Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

match atsea spring #153

Merged
merged 7 commits into from
Aug 30, 2023
Merged

match atsea spring #153

merged 7 commits into from
Aug 30, 2023

Conversation

andermi
Copy link
Collaborator

@andermi andermi commented Jul 13, 2023 •
edited
Loading

Adds spring params to yaml

merge #156 and #158 first

requires hamilton8415/FreeSurfaceHydrodynamics#5

@andermi andermi marked this pull request as ready for review August 28, 2023 22:15
@andermi andermi changed the base branch from main to andermi/add_vectorized_batch_mode August 28, 2023 22:18
hamilton8415
hamilton8415 approved these changes Aug 30, 2023
View reviewed changes
Copy link
Collaborator

@hamilton8415 hamilton8415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So much templating! I know you've been testing with these and the spring results have looked good.

Base automatically changed from andermi/add_vectorized_batch_mode to andermi/fix_fshydro_includes August 30, 2023 23:20
@andermi andermi merged commit 9ba7b4a into andermi/fix_fshydro_includes Aug 30, 2023
0 of 2 checks passed
@andermi andermi deleted the andermi/atsea_spring branch August 30, 2023 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hamilton8415 hamilton8415 hamilton8415 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andermi @hamilton8415