Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use ros_buildfarm old_release_set.Dockerfile.em #65

Merged
merged 1 commit into from
Jun 8, 2019

Conversation

mikaelarguedas
Copy link
Contributor

@mikaelarguedas mikaelarguedas commented Jun 6, 2019

Requires ros-infrastructure/ros_buildfarm#637

Now that this template will start being used on more recent distros as well as non Ubuntu distros. We should not apply the sed for old-releases unconditionnaly.

This PR switches to using the template used by the ros_buildfarm instead

@nuclearsandwich FYI

@mikaelarguedas
Copy link
Contributor Author

Due to difficulties to reach packages.ros.org without too much latency, I haven't been able to generate all dockerfiles and see if the resulting Dockerfiles makes sense.
@nuclearsandwich could you try to generate them along #63 + #64 and push the resulting files to osrf/docker_images#273 if they look valid? Thanks!

@mikaelarguedas
Copy link
Contributor Author

just read osrf/docker_images#273 (comment),
I also noticed that the old ros distro target some ubuntu versions not listed in the buildfarm template.

So let's defer this improvement to allow osrf/docker_images#273 to move forward

@mikaelarguedas
Copy link
Contributor Author

now that ros-infrastructure/ros_buildfarm#637 has been merged, I believe this is ready for review/merge

@ruffsl ruffsl merged commit 730f4fc into master Jun 8, 2019
@tfoote tfoote deleted the use_old_release_template branch June 8, 2019 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants