Report formatter base #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blast545
requested changes
Jul 4, 2024
database/scripts/generate_report.rb
Outdated
| @@ -51,3 +50,4 @@ def generate_report(report_name, exclude_set) | |||
| end | |||
|
|
|||
| generate_report(options[:report_name], options[:exclude]) | |||
| puts report_name | |||
There was a problem hiding this comment.
The default report name is the current DateTime. Because of this, the report name varies every minute.
The idea is to keep track of which report was generated.
| JOB_URL_PATTERN = { | ||
| /^gz|^sdformat|^ros_gz/ => 'https://build.osrfoundation.org/job/', | ||
| /^[A-Z]ci/ => 'https://build.ros2.org/job/', | ||
| /^nightly_/ => 'https://ci.ros2.org/job/', |
There was a problem hiding this comment.
What about packaging jobs?
I think this could cause a maintenance burden, can we pull this directly from database/fetcher?
There was a problem hiding this comment.
The database does not contain any information about the server we're fetching the information.
We can modify the fetcher to add a new domain column to server_status table. WDYT?
There was a problem hiding this comment.
Like we had avoided it, but I think it's worth doing it now that we are favoring pulling the info coming from the dev repos
database/scripts/format_report.rb
Outdated
Comment on lines
12
to
14
| # These are not implemented yet!!! | ||
| report['urgent']['test_regressions_consecutive'] = [] | ||
| report['urgent']['test_regressions_flaky'] = [] |
There was a problem hiding this comment.
I think this PR should wait until this is finished, otherwise could be misleading even for the internal team.
Crola1702
force-pushed
the
feat/report-formatter
branch
from
c5dd1e0 to
2d14e8c
Compare
|
Current report with changes:
UrgentMaintenancePending |
|
Converted to draft until all urgent section is finished |
Crola1702
force-pushed
the
feat/report-formatter
branch
from
2d14e8c to
c67c1d3
Compare
|
Current report:
UrgentTest regressions consecutive
MaintenancePending |
Crola1702
force-pushed
the
feat/report-formatter
branch
from
c67c1d3 to
295b236
Compare
|
Current state of report format: UrgentBuild regressions
Test regressions consecutive
Test regressions flaky
MaintenancePending |
|
@Blast545 I added the "Reports" column adding the URL. I think to prevent daily mentions to multiple issues we should wrap the links in backquotes (`). WDYT? EDIT: I applied the change from above. Let me know if you think leaving the link as normal is a better idea |
Crola1702
force-pushed
the
feat/report-formatter
branch
from
8b57921 to
b08b4dc
Compare
|
Current state of report format: UrgentBuild regressions
Test regressions consecutiveTest regressions
Warnings
Test regressions flakyTest regressions
MaintenancePending |
|
@Blast545 this is ready to be reviewed |
claraberendsen
approved these changes
Jul 10, 2024
Signed-off-by: Crola1702 <[email protected]>
Signed-off-by: Crola1702 <[email protected]>
Signed-off-by: Crola1702 <[email protected]>
Signed-off-by: Crola1702 <[email protected]>
Signed-off-by: Crola1702 <[email protected]>
Signed-off-by: Crola1702 <[email protected]>
Signed-off-by: Crola1702 <[email protected]>
Signed-off-by: Crola1702 <[email protected]>
Signed-off-by: Crola1702 <[email protected]>
Signed-off-by: Crola1702 <[email protected]>
Signed-off-by: Crola1702 <[email protected]>
Signed-off-by: Crola1702 <[email protected]>
Crola1702
force-pushed
the
feat/report-formatter
branch
from
b08b4dc to
b3cc556
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of #57
#62 adds
generate_report.rbscript, which generates a json file with daily issues (e.g., buildfarm-report_2024-06-25_12-10.json). The idea is to parse this report into a Markdown format to be posted daily in buildfarmer log report.Current output is pretty simple:
Example output:
urgent
build_regressions
Emtpy!!test_regressions_consecutive
Emtpy!!test_regressions_flaky
maintenance
Emtpy!!jobs_failing
Emtpy!!gh_issues_reported
Emtpy!!tests_disabled
pending
Emtpy!!test_regressions_all
Emtpy!!test_regressions_known
Emtpy!!build_regressions_known