Report: Jobs Last Success Date subsection (#75) PR comments

Signed-off-by: Crola1702 <[email protected]>
osrf · Aug 2, 2024 · 5fbfc5b · 5fbfc5b
1 parent a6fb47c
commit 5fbfc5b
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 6 deletions.
diff --git a/database/scripts/format_report.rb b/database/scripts/format_report.rb
@@ -10,7 +10,7 @@
 report['urgent']['build_regressions'] = ReportFormatter::build_regressions(report['urgent']['build_regressions'])
 report['urgent']['test_regressions_consecutive'] = ReportFormatter::test_regressions_consecutive(report['urgent']['test_regressions_consecutive'])
 report['urgent']['test_regressions_flaky'] = ReportFormatter::test_regressions_flaky(report['urgent']['test_regressions_flaky'])
-report['maintenance']['jobs_failing'] = ReportFormatter::jobs_failing(report['maintenance']['jobs_failing'])
+report['maintenance']['jobs_last_success_date'] = ReportFormatter::jobs_last_success_date(report['maintenance']['jobs_last_success_date'])
 
 # Sample output:
 # puts report['urgent']['build_regressions']

diff --git a/database/scripts/generate_report.rb b/database/scripts/generate_report.rb
@@ -32,7 +32,7 @@ def generate_report(report_name, exclude_set)
             'test_regressions_flaky' => urgent_flaky_test_regressions = BuildfarmToolsLib::flaky_test_regressions(group_issues: true),
        },
        'maintenance' => {
-            'jobs_failing' => maintenance_jobs_failing = BuildfarmToolsLib::jobs_failing(days_exclude: 7),
+            'jobs_last_success_date' => maintenance_jobs_last_success_date = BuildfarmToolsLib::jobs_last_success_date(older_than_days: 7),
             'gh_issues_reported' => [],
             'tests_disabled' => [],
        },

diff --git a/database/scripts/lib/buildfarm_tools.rb b/database/scripts/lib/buildfarm_tools.rb
@@ -98,7 +98,7 @@ def self.jobs_never_passed
     run_command('./sql_run.sh jobs_never_passed.sql')
   end
 
-  def self.jobs_failing(days_exclude: 0)
+  def self.jobs_last_success_date(older_than_days: 0)
     # Keys: job_name, last_success
     out = []
     jobs_never_passed.each do |e|
@@ -107,7 +107,7 @@ def self.jobs_failing(days_exclude: 0)
 
     jobs_last_success.each do |e|
       last_success = DateTime.parse(e['last_success_time']) 
-      next if last_success > (Date.today - days_exclude)
+      next if last_success > (Date.today - older_than_days)
       out << {"job_name" => e["job_name"], "last_success" => last_success.strftime('%Y-%m-%d')}
     end
     out

diff --git a/database/scripts/lib/report_formatter.rb b/database/scripts/lib/report_formatter.rb
@@ -128,7 +128,7 @@ def self.test_regressions_flaky(tr_array)
     out
   end
 
-  def self.jobs_failing(job_array)
+  def self.jobs_last_success_date(job_array)
     return "" if job_array.empty?
     table = "| Job Name | Last Success |\n| -- | -- |\n"
     job_array.each do |job|
@@ -139,7 +139,7 @@ def self.jobs_failing(job_array)
 
   def self.format_report(report_hash)
     # Use <details> and <summary> tags to prevent long reports
-    details_subcategories = ['test_regressions_flaky', 'jobs_failing']
+    details_subcategories = ['test_regressions_flaky', 'jobs_last_success_date']
     output_report = ""
 
     report_hash.each_pair do |category, subcategory_hash|