Update software versions in CI, including enabling Python 3.12 wheels #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Python 3.7 has fallen out of support and could not install the latest versions of build tools like setuptools and cibuildwheel. Also, the setup-python action was updated to v5 as the v1 version was producing warnings about end of life. With the latest version of setuptools, `python setup.py sdist` no longer works so the sdist creation step was modified to use pypa/build instead.
The main upload-artifact action no longer supports merging so the artifacts must be uploaded independently with unique names and merged in a follow up step using subaction from upload-artifact called "merge".
|
|
bstellato
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main purpose of this PR is to update the version of Python used in CI to generate the wheel files. The current version is Python 3.7 which is out of support. Using 3.7 leads to outdated versions of setuptools and cibuildwheel being installed. Most significantly, this means that the version of cibuildwheel used does not build wheels for Python 3.12.
While updating the Python version, I noticed warnings about GitHub actions versions being outdated and going out of support soon, so I updated them as well. That work could be split out of the PR if preferred.
Detailed list of distinct changes:
python setup.py sdistwithpython -m build --sdistsince the former was deprecated and does not work with the latest setuptools.