Skip to content

Commit

Permalink
insisting on numpy<2 in dev extra; not enforcing numpy>=2 otherwise
Browse files Browse the repository at this point in the history
  • Loading branch information
vineetbansal committed Jul 27, 2024
1 parent 3594b2d commit 552dcff
Showing 1 changed file with 6 additions and 4 deletions.
10 changes: 6 additions & 4 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,7 @@ authors = [
]
dependencies = [
"jinja2",
# Building with numpy 2.0 is compatible with numpy 1.x, but it
# is only available on Python 3.9+
"numpy >= 2.0.0; python_version > '3.8'",
"oldest-supported-numpy; python_version <= '3.8'",
"numpy>=1.7",
"qdldl",
"scipy>=0.13.2",
"setuptools",
Expand All @@ -32,12 +29,17 @@ dev = [
"pre-commit",
"pytest>=6",
"torch",

# Exclude scipy 1.12 because the random sparse array function started returning
# the transpose of the original, breaking the unit tests. This was fixed in 1.13.0.
# This shouldn't actually affect the users, so there shouldn't be a need to exclude
# 1.12 on a user's machine.
# ref: https://github.com/scipy/scipy/issues/20027
"scipy!=1.12.0",

# As of 07/27/24, torch on many platforms (intel macs, Windows), cannot seem to coexist
# with numpy>=2; Since we do need torch for development purposes, we'll pin np<2
"numpy<2"
]
mkl = [
"osqp-mkl",
Expand Down

0 comments on commit 552dcff

Please sign in to comment.