Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: block-sdk import now uses forked version #8985

Merged
merged 5 commits into from
Feb 10, 2025
Merged

Conversation

crnbarr93
Copy link
Contributor

What is the purpose of the change

This changes syncs the main branch with the patch applied to v28.x which fixes an issue with the block-sdk.

@crnbarr93 crnbarr93 added the V:state/compatible/no_backport State machine compatible PR, depends on prior breaks label Feb 4, 2025
@crnbarr93 crnbarr93 requested a review from PaddyMc February 4, 2025 13:00
@crnbarr93 crnbarr93 marked this pull request as ready for review February 4, 2025 13:01
Copy link
Contributor

coderabbitai bot commented Feb 4, 2025

Walkthrough

The pull request updates the project changelog by adding a new entry under the "Unreleased" section. This entry, placed in the "State Compatible" subsection, details that the block-sdk import now uses a forked version as referenced by pull request #8985. No changes were made to public APIs or exported entities.

Changes

File Change Summary
CHANGELOG.md Added a new line under "Unreleased" in the "State Compatible" section indicating a build-related change: block-sdk import now uses a forked version (#8985).

Suggested labels

V:state/compatible/backport, A:backport/v28.x

Suggested reviewers

  • nicolaslara
  • czarcas7ic
  • ValarDragon

Tip

🌐 Web search-backed reviews and chat
  • We have enabled web search-based reviews and chat for all users. This feature allows CodeRabbit to access the latest documentation and information on the web.
  • You can disable this feature by setting web_search: false in the knowledge_base settings.
  • Please share any feedback in the Discord discussion.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 351b03a and 77fb6b7.

⛔ Files ignored due to path filters (2)
  • go.mod is excluded by !**/*.mod
  • go.sum is excluded by !**/*.sum, !**/*.sum
📒 Files selected for processing (1)
  • CHANGELOG.md (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (10)
  • GitHub Check: e2e
  • GitHub Check: go-split-test-files
  • GitHub Check: osmosisd-linux-arm64
  • GitHub Check: osmosisd-darwin-arm64
  • GitHub Check: osmosisd-linux-amd64
  • GitHub Check: osmosisd-darwin-amd64
  • GitHub Check: check-proto
  • GitHub Check: Run golangci-lint
  • GitHub Check: test
  • GitHub Check: Summary
🔇 Additional comments (1)
CHANGELOG.md (1)

51-51: Changelog Entry for PR [#8985] Looks Good.
The new entry under the "State Compatible" section clearly indicates that the block‑sdk import now uses a forked version, and it is formatted consistently with the project’s changelog guidelines.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

go.mod Outdated
// Direct block-sdk branch link: https://github.com/osmosis-labs/block-sdk/tree/release/v2.x.x, current branch: release/v2.x.x
// Direct commit link: https://github.com/osmosis-labs/block-sdk/commit/a86e729f843d36392393a8ff6a14c9fbc15f2fcc
// Direct tag link: https://github.com/osmosis-labs/block-sdk/releases/tag/v2.1.5-patch-1
github.com/skip-mev/block-sdk/v2 => github.com/osmosis-labs/block-sdk/v2 v2.1.5-patch-1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think we should just tag v2.1.6 here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, that sounds like a good idea to me. Want me to tag and update the import here?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please 🙇

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PaddyMc PaddyMc closed this Feb 10, 2025
@PaddyMc PaddyMc reopened this Feb 10, 2025
@PaddyMc PaddyMc merged commit 304a396 into main Feb 10, 2025
20 checks passed
@PaddyMc PaddyMc deleted the connor/block-sdk-bump branch February 10, 2025 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
V:state/compatible/no_backport State machine compatible PR, depends on prior breaks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants