Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add local cache inside the takerfee (backport #8148) #8261

Merged
merged 1 commit into from
May 14, 2024
Merged

Add local cache inside the takerfee (backport #8148) #8261

merged 1 commit into from
May 14, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented May 13, 2024

What is the purpose of the change

Remove parameter unmarshal time from charging TakerFee from poolmanager

Testing and Verifying

Covered by existing unit tests

Documentation and Release Note

  • Changelog entry added to Unreleased section of CHANGELOG.md? - DONE

Where is the change documented?

  • Specification (x/{module}/README.md)
  • Osmosis documentation site
  • Code comments?
  • N/A

Summary by CodeRabbit

  • New Features
    • Added new fields to enhance fee management in the trading platform.
  • Enhancements
    • Improved the fee retrieval process to ensure more efficient and accurate fee handling.
This is an automatic backport of pull request #8148 done by [Mergify](https://mergify.com).

@ValarDragon @mergify
Add local cache inside the takerfee (#8148)
929eab0 
* Add local cache inside the takerfee

* add error handling

* Add Changelog

* Fix cache per @adam's comment

* Update x/poolmanager/taker_fee.go

(cherry picked from commit b8fd642)
@PaddyMc PaddyMc merged commit 1d6ebd2 into v25.x May 14, 2024
1 check passed
@PaddyMc PaddyMc deleted the mergify/bp/v25.x/pr-8148 branch May 14, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PaddyMc PaddyMc PaddyMc approved these changes

@czarcas7ic czarcas7ic Awaiting requested review from czarcas7ic czarcas7ic is a code owner

@p0mvn p0mvn Awaiting requested review from p0mvn p0mvn is a code owner

@mattverse mattverse Awaiting requested review from mattverse mattverse is a code owner

@AlpinYukseloglu AlpinYukseloglu Awaiting requested review from AlpinYukseloglu AlpinYukseloglu is a code owner

Assignees

@ValarDragon ValarDragon

Labels
C:x/poolmanager
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PaddyMc @ValarDragon