Add message to 1CT and direct sign

[mattupham]

What is the purpose of the change:

Linear Task

Brief Changelog

Testing and Verifying

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
osmosis-frontend	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 20, 2024 6:28pm

4 Skipped Deployments

Name	Status	Preview	Comments	Updated (UTC)
osmosis-frontend-datadog	⬜️ Ignored (Inspect)			Sep 20, 2024 6:28pm
osmosis-frontend-dev	⬜️ Ignored (Inspect)			Sep 20, 2024 6:28pm
osmosis-frontend-edgenet	⬜️ Ignored (Inspect)			Sep 20, 2024 6:28pm
osmosis-testnet	⬜️ Ignored (Inspect)			Sep 20, 2024 6:28pm

[coderabbitai]

Walkthrough

The changes introduce a new message type, "/osmosis.lockup.MsgBeginUnlocking", into the system, affecting multiple components. The AccountStore class now includes this message type in its conditional logic to determine transaction signing requirements. Additionally, the new message type is incorporated into the AvailableOneClickTradingMessages type and is added to the message types handled by the useCreateOneClickTradingSession function. These modifications expand the functionality related to lockup operations within the Osmosis protocol.

Changes

File Path	Change Summary
packages/stores/src/account/base.ts	Added a condition to check for "/osmosis.lockup.MsgBeginUnlocking" in the AccountStore class.
packages/types/src/one-click-trading-types.ts	Updated AvailableOneClickTradingMessages to include "/osmosis.lockup.MsgBeginUnlocking".
packages/web/hooks/mutations/one-click-trading/use-create-one-click-trading-session.tsx	Added "/osmosis.lockup.MsgBeginUnlocking" to the message types handled by useCreateOneClickTradingSession.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant TradingSession
    participant AccountStore

    User->>TradingSession: Initiate one-click trading
    TradingSession->>AccountStore: Check message types
    AccountStore-->>TradingSession: Include MsgBeginUnlocking
    TradingSession->>User: Complete trading session

Loading

---

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 6db052a and 378c22c.

Files selected for processing (3)

• packages/stores/src/account/base.ts (1 hunks)
• packages/types/src/one-click-trading-types.ts (1 hunks)
• packages/web/hooks/mutations/one-click-trading/use-create-one-click-trading-session.tsx (1 hunks)

Additional comments not posted (3)

packages/types/src/one-click-trading-types.ts (1)

9-10: LGTM! Verify the usage of the new message type in other parts of the codebase.

The addition of the new message type "/osmosis.lockup.MsgBeginUnlocking" to the AvailableOneClickTradingMessages type is consistent with the existing structure and expands the functionality of the one-click trading system.

Please ensure that other parts of the codebase that handle or process one-click trading messages are updated to support this new message type.

Run the following script to verify the usage of the new message type:

Verification successful

---

Verification successful: New message type properly integrated and used

The new message type "/osmosis.lockup.MsgBeginUnlocking" has been successfully added to the AvailableOneClickTradingMessages type and is being used appropriately across the codebase. Key observations:

• Correctly added in packages/types/src/one-click-trading-types.ts
• Utilized in one-click trading session creation (packages/web/hooks/mutations/one-click-trading/use-create-one-click-trading-session.tsx)
• Integrated into account base logic (packages/stores/src/account/base.ts)
• Properly defined in protocol buffer related files (packages/proto-codecs/src/codegen/osmosis/lockup/)

The changes appear to be consistent and well-integrated throughout the relevant parts of the codebase.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the usage of the new message type "/osmosis.lockup.MsgBeginUnlocking" in the codebase.

# Test: Search for the message type usage. Expect: Occurrences in relevant files.
rg --type typescript $'/osmosis\.lockup\.MsgBeginUnlocking'

Length of output: 95

---

Script:

#!/bin/bash
# Description: Verify the usage of the new message type "/osmosis.lockup.MsgBeginUnlocking" in the codebase.

# Test 1: Search for the message type usage across all files
echo "Searching for '/osmosis.lockup.MsgBeginUnlocking' usage:"
rg '/osmosis\.lockup\.MsgBeginUnlocking'

# Test 2: Verify that we can find the file where the message type is defined
echo -e "\nVerifying search functionality by looking for the file where the message type is defined:"
rg -l 'AvailableOneClickTradingMessages'

Length of output: 3471

packages/web/hooks/mutations/one-click-trading/use-create-one-click-trading-session.tsx (1)

254-254: LGTM!

The addition of the "/osmosis.lockup.MsgBeginUnlocking" message type to the allowedMessages array is a valid change that expands the functionality of the one-click trading session to include the ability to unlock assets. The change is consistent with the existing pattern and is unlikely to introduce any issues.

packages/stores/src/account/base.ts (1)

843-846: LGTM!

The function correctly determines if a transaction should be signed using one-click trading based on the provided conditions. The logic is sound and there are no apparent issues.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  -- I pushed a fix in commit <commit_id>, please review it.
  -- Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  -- @coderabbitai generate unit testing code for this file.
  -- @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  -- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  -- @coderabbitai read src/utils.ts and generate unit testing code.
  -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[JoseRFelix]

@mattupham Is this PR still relevant?