-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable OKTO Wallet Official Support on Osmosis #3714
base: stage
Are you sure you want to change the base?
Conversation
@SrijanCoinDCX is attempting to deploy a commit to the OsmoLabs Team on Vercel. A member of the Team first needs to authorize it. |
WalkthroughThe updates introduce support for the Okto wallet extension in the Cosmos wallet ecosystem. This involves enhancing the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant WalletList
participant WalletRegistry
User->>WalletList: Request wallet options
WalletList-->>User: Return list of wallets (includes Okto)
User->>WalletRegistry: Select Okto wallet
WalletRegistry->>User: Load Okto wallet features
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Outside diff range, codebase verification and nitpick comments (1)
packages/web/config/wallet-registry.ts (1)
157-165
: Missing Dependency for OKTO Wallet EntryThe
@cosmos-kit/okto-extension
package is not listed as a dependency inpackage.json
, which may cause the lazy loading function to fail at runtime. Ensure that this package is added to the project's dependencies to resolve the issue.
- Add
@cosmos-kit/okto-extension
to thepackage.json
dependencies.Analysis chain
Addition of OKTO wallet entry is well-structured.
The new entry for the OKTO wallet is consistent with existing entries in the
CosmosWalletRegistry
. The properties are correctly set, including lazy loading and features.Verify that the logo path and lazy loading function are correct.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the logo path and lazy loading function for the OKTO wallet entry. # Test: Check if the logo file exists. Expect: The file `/wallets/okto.png` should exist. if [ ! -f "packages/web/public/wallets/okto.png" ]; then echo "Logo file for OKTO wallet is missing." else echo "Logo file for OKTO wallet is present." fi # Test: Verify the lazy loading function. Expect: The function should correctly import the `OktoExtensionWallet`. ast-grep --lang typescript --pattern 'export const OktoExtensionWallet = $_;' @cosmos-kit/okto-extensionLength of output: 319
Script:
#!/bin/bash # Check if @cosmos-kit/okto-extension is listed as a dependency in package.json if grep -q '"@cosmos-kit/okto-extension"' package.json; then echo "@cosmos-kit/okto-extension is listed as a dependency." else echo "@cosmos-kit/okto-extension is not listed as a dependency." fi # Verify the import path for @cosmos-kit/okto-extension in the codebase rg --glob '!node_modules/*' '@cosmos-kit/okto-extension' -A 2Length of output: 909
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@SrijanCoinDCX Thank you for opening this PR! The build is failing. Could you merge with |
Hi, @JoseRFelix . Thank you for your response. I have synced my PR with stage, as you advised; could you please review it again? |
@SrijanCoinDCX looks like the build is still failing. I would rebase with stage, clear out everything and reinstall. |
Okay, @MaxMillington, let me know if anything needs to be fixed or improved on my end. |
What is the purpose of the change:
This PR introduces official support for the OKTO wallet on the Osmosis platform. By integrating OKTO wallet, we aim to enhance user experience and expand accessibility to the Osmosis ecosystem.
Linear Task
Link to Linear Task
Brief Changelog
Testing and Verifying
This change has been tested locally by rebuilding the website and verified content and links are expected.