implement getNativeAssetPrice #3666
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Skipped Deployments
|
p0mvn
commented
Aug 3, 2024
Comment on lines
+19
to
+35
| /** Finds the fiat value of a single unit of a given asset denominated in USDC. | ||
| * Assets can be identified either by `coinMinimalDenom`. | ||
| * @throws if the coinMinimalDenom is not given or fails to fetch the price from data source */ | ||
| export async function getNativeAssetPrice( | ||
| coinMinimalDenom: string | ||
| ): Promise<Dec> { | ||
| if (!coinMinimalDenom) { | ||
| throw new Error("coinDenom is required"); | ||
| } | ||
|
|
||
| return cachified({ | ||
| key: `asset-price-nat-${coinMinimalDenom}`, | ||
| cache: pricesCache, | ||
| ttl: 1000 * 10, // 10 seconds | ||
| getFreshValue: () => getPriceFromSidecar(coinMinimalDenom), | ||
| }); | ||
| } |
There was a problem hiding this comment.
@jonator instead of doing the factory pattern that we discussed, I simply introduced another helper that handles native pricing to decouple the logic and simplify the majority of the chain use-cases while keeping the abstraction necessary for bridging.
Base automatically changed from
roman/remove-source-denom
to
roman/remove-pools-prices
August 5, 2024 06:12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements
getNativeAssetPrice, which retrieves prices from the sidecar with no other fallbacks.This use case helps decouple 90% of the native chain pricing needs while retaining the original abstraction for bridging needs.
Testing
Upon approval, I will request QA.