(Wallet Addition) Add Galaxy Station wallet #3395
Conversation
|
@echel0n-HX is attempting to deploy a commit to the OsmoLabs Team on Vercel. A member of the Team first needs to authorize it. |
|
Warning Rate limit exceeded@echel0n-HX has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 51 minutes and 17 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. WalkthroughThe recent updates enhance the Cosmos wallet integration by adding support for the Galaxy Station extension. This includes incorporating the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Outside diff range and nitpick comments (1)
packages/web/config/wallet-registry.ts (1)
Line range hint
201-201: Optimize the exponential backoff mechanism.The static analysis tool recommends using the exponentiation operator
**instead ofMath.powfor clarity and modern JavaScript practices.- setTimeout(resolve, Math.pow(2, retryCount) * 100) + setTimeout(resolve, (2 ** retryCount) * 100)
| @@ -5,6 +5,7 @@ import path from "node:path"; | |||
| import { cdcwalletExtensionInfo } from "@cosmos-kit/cdcwallet-extension"; | |||
| import { Wallet as DefaultWallet } from "@cosmos-kit/core"; | |||
| import { cosmostationExtensionInfo } from "@cosmos-kit/cosmostation-extension"; | |||
| import { galaxyStationExtensionInfo } from "@cosmos-kit/galaxy-station-extension"; | |||
There was a problem hiding this comment.
Tip
Codebase Verification
Package @cosmos-kit/galaxy-station-extension is missing
The package @cosmos-kit/galaxy-station-extension is neither listed in package.json nor installed in node_modules. Please ensure that it is added to the dependencies or devDependencies in package.json and installed to avoid runtime errors.
- Add
@cosmos-kit/galaxy-station-extensiontopackage.json. - Run
npm installoryarn installto install the package.
Analysis chain
New import added for Galaxy Station wallet.
This import is necessary for the addition of the Galaxy Station wallet to the CosmosKitWalletList. Ensure that the package @cosmos-kit/galaxy-station-extension is correctly installed and listed in package.json to avoid runtime errors.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify the package '@cosmos-kit/galaxy-station-extension' is installed.
# Test: Search for the package in package.json. Expect: Package should be listed.
cat package.json | jq '.dependencies["@cosmos-kit/galaxy-station-extension"]'
Length of output: 84
Script:
#!/bin/bash
# Description: Verify if the package '@cosmos-kit/galaxy-station-extension' is listed under devDependencies.
# Test: Search for the package in devDependencies in package.json. Expect: Package should be listed.
cat package.json | jq '.devDependencies["@cosmos-kit/galaxy-station-extension"]'
Length of output: 87
Script:
#!/bin/bash
# Description: Verify if the package '@cosmos-kit/galaxy-station-extension' is installed in node_modules.
# Test: Search for the package in node_modules. Expect: Package directory should exist.
if [ -d "node_modules/@cosmos-kit/galaxy-station-extension" ]; then
echo "Package is installed in node_modules."
else
echo "Package is not installed in node_modules."
fi
Length of output: 155
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
|
I enough Osmo in my wallet for the tx but wallet is not selecting Osmo and also Osmo is not included in the gas token list. |
|
@echel0n-HX sometimes the networks are disabled and deposit/withdraw doesn't pop up the tx window. |
|
I just did a Chihuahua -> Osmosis without issue https://www.mintscan.io/osmosis/tx/3B13D46E6AF9F971A0D3F34F3A3E4612787DFDED93C4C916B44CA7F8C7DE3151 As for the Sentinel issue, most likely its just the LCD, I'll find a better more stable one to swap it to. |
|
@echel0n-HX this is my Osmosis address but as you can see in the video above Osmo is not included in the gas fee token list |
|
@CryptoAssassin1 I'm not able to re-produce that issue you are having swapping Atom -> Osmosis, please see below TX of a successful swap, could of it been a disabled network at the time, I noticed the warning triangle at the top. https://www.mintscan.io/osmosis/tx/30DB56427B0B80B94C0AD02F2AF3F38A6C5EDCF311AC981B551D87449C642058 |
|
@kamal-sutra I've updated the LCD endpoint for Sentinel and performed a Osmosis -> Sentinel swap |
|
@echel0n-HX checked again and still same issue |
|
@CryptoAssassin1 what dev env are you testing this from, I'm currently using Win 11 and Edge with Galaxy Station Wallet v1.0.51 |
|
@echel0n-HX im using Ubuntu 22.04.1 LTS and extension version 1.0.51 |
|
@CryptoAssassin1 I believe the issue you are having is isolated to Chrome on Linux, I tested on Edge and Chrome on Windows without issues so far, are you able to test on a Windows box ? |
|
|
@echel0n-HX i dont think its OS and browser issue. |
|
@kamal-sutra thanks for that info, I am now able to reproduce @CryptoAssassin1 issue and am working to resolve it. |
echel0n-HX
force-pushed
the
galaxy-station-wallet
branch
from
99ba4ae
to
717bfa5
Compare
echel0n-HX
force-pushed
the
galaxy-station-wallet
branch
from
717bfa5
to
e21efe8
Compare
|
@kamal-sutra I removed the |
|
@CryptoAssassin1 @kamal-sutra deploy authorized |
|
@CryptoAssassin1 @kamal-sutra so after extensive debugging, what I have determined is that osmosis zone app is posting a request to Galaxy Station extension with the wrong denom, its using Its not cosmos-kit issue either, as we have tested on another app that uses cosmos-kit to swap whale -> to osmosis and logged the posted request, the proper denom of I should also note that I did try whale -> osmosis as well on the latest osmosis zone preview, same issue with the wrong denom. Any ideas ? |
@JoseRFelix perhaps you have some context here? |
|
@kamal-sutra regarding the max amount and gas fee issues due to it, it seems this was brought up before when Terra Station was added and it was determined the issue to be on the side of osmosis app possibly, please see previous thread regarding this #2210 (comment) |
|
what next steps are required to get this moving forward ? the gas fee denom issue doesn't look like its something on our side that is fixable, and may need to be resolved on osmosis app side, as long as there is osmo in the end-users wallet, tx's go through fine. |
|
@echel0n-HX does galaxy station accept alternative fee tokens? Our FE suggests alternative tokens to pay fees depending on the user's balance |
|
@jonator based on the gas fee denom passed in via the TX request, and if there is not enough of it to cover the gas, galaxy station will provide the end-user the ability to swap other coins using swap.io to get the required amount of said gas fee denom. so in the case of the gas denom required being osmo, then osmo needs to be sent as the gas fee denom in the TX request, if there is not enough osmo in the end-users wallet, they will be able to swap other tokens to get more osmo, such as swapping whale -> osmo or chihuahua -> osmo. the problem right now with trying to swap lunc through swap.io is that there are no routes for it, and its an issue that swap.io is looking into still on their end. is there a way to have osmosis frontend pass in osmo instead of passing in alternative fee tokens based on balance specifically for galaxy station ? also, this same issue plagues terra station. |
|
@jonator another idea would be to implement a dropdown to allow the end-user to select the gas denom they wish to use for the fee, that will then be passed on in the TX request to the connected wallet, sort that dropdown by balance as well. You could further combine this with a gas denom allow list that can be set by each wallet profile in wallet-registry.ts, much like you have already for available chains. |
What is the purpose of the change:
Include Galaxy Station Cosmos-Kit wallet