Add IBC status provider tests

[jonator]

What is the purpose of the change:

I accidentally committed the IBC provider tests to stage in the past, but they are quite simple.

This PR introduces the test suite for the IBC status provider, which has quite a few async operations. In short, it sets up a Promise.wait to either wait for an IBC ack confirming the transfer, or for the IBC timeout height to be reached on the counterparty chain from polling.

Linear Task

Linear Task URL

Brief Changelog

• Adds unit tests for IBC transfer status provider
• Makes minor improvements to the status provider and providers it uses

Testing and Verifying

• All tests pass

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
osmosis-frontend	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 12, 2024 5:35pm

4 Ignored Deployments

Name	Status	Preview	Comments	Updated (UTC)
osmosis-frontend-datadog	⬜️ Ignored (Inspect)	Visit Preview		Jun 12, 2024 5:35pm
osmosis-frontend-dev	⬜️ Ignored (Inspect)	Visit Preview		Jun 12, 2024 5:35pm
osmosis-frontend-edgenet	⬜️ Ignored (Inspect)			Jun 12, 2024 5:35pm
osmosis-testnet	⬜️ Ignored (Inspect)	Visit Preview		Jun 12, 2024 5:35pm

[coderabbitai]

Walkthrough

The updates introduce tests for IBC transfer status tracking, refactor the IBCTransferStatusProvider class for better timeout and error handling, and add default values in the TxTracer class. URL paths for transaction pages were corrected in mock chain data. Additionally, console errors in test files for SquidTransferStatusProvider and SkipTransferStatusProvider were silenced for cleaner test outputs.

Changes

Files/Groups	Change Summaries
ibc/__tests__/ibc-transfer-status.spec.ts	Added tests for IBC transfer statuses including handling errors and generating explorer URLs.
ibc/transfer-status.ts	Refactored IBCTransferStatusProvider class for better handling of timeouts and cleanup.
tx/src/tracer.ts	Added default value for wsEndpoint parameter in TxTracer class constructor.
__tests__/mock-chains.ts	Updated transaction page URLs for various chains to correct explorer pages.
skip/__tests__/skip-transfer-status.spec.ts	Refactored mocks and silenced console errors in SkipTransferStatusProvider tests.
squid/__tests__/squid-transfer-status.spec.ts	Added mock implementation to silence console errors in SquidTransferStatusProvider tests.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant IBCTransferStatusProvider
    participant TxTracer
    participant Explorer

    User->>IBCTransferStatusProvider: Initiate IBC Transfer
    IBCTransferStatusProvider->>TxTracer: Track Transaction Status
    TxTracer-->>IBCTransferStatusProvider: Status Update
    IBCTransferStatusProvider-->>User: Transfer Status
    IBCTransferStatusProvider->>Explorer: Generate Explorer URL
    Explorer-->>IBCTransferStatusProvider: URL
    IBCTransferStatusProvider-->>User: Explorer URL

Loading

Poem

In the land of code, where data flows,
IBC transfers track their woes.
With timeouts handled, errors tamed,
Explorer links properly named.
Console whispers now at rest,
Our tests are cleaner, passing best.
🐇✨

---

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 5c2108c and e7bc76a.

Files selected for processing (1)

• packages/bridge/src/squid/tests/squid-transfer-status.spec.ts (1 hunks)

Files skipped from review as they are similar to previous changes (1)

• packages/bridge/src/squid/tests/squid-transfer-status.spec.ts

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[jonator]

Investigating why MSW stopped working in bridge pkg

[coderabbitai]

Actionable comments posted: 4

Outside diff range and nitpick comments (1)

packages/bridge/src/skip/__tests__/skip-transfer-status.spec.ts (1)

57-62: Ensure consistent handling of JSON parameters in test cases.

The handling of JSON parameters in trackTxStatus calls is consistent, which is good. However, consider abstracting this into a function to reduce redundancy and improve maintainability.

Also applies to: 75-80

[JoseRFelix]

LGTM!