Publish Stage #3303
Merged
Publish Stage #3303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jonator
commented
Jun 6, 2024
•
jonator
commented
- Gas estimation optimizations and edge case fixes
- Should reduce the number of invalid simulation queries being sent (these are handled gracefully by the UI, the user is unaware)
- Exclusively log failed swap errors for transactions failed on chain
- This should make Amplitude charts explicitly show failed swaps due to a malformed on chain tx: bad routes, slippage, or other
* fix invalid estimation when clearing input * fix filter spent coins by sender * feedback
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
jonator
requested review from
Amosel,
MaxMillington,
DavideSegullo,
JoseRFelix,
mattupham,
fabryscript,
yury-dubinin and
kamal-sutra
* check for tx code for rejecting promise * only reject with failed txs * make error handling more consistent * fixes
DavideSegullo
approved these changes
Jun 6, 2024
* Bump types/node and typescript * up yarn.lock
MaxMillington
approved these changes
Jun 6, 2024
* add import/no-default-export * Add overrides for next.js pages * wallet-tutorial * QRCodeView * useGetEarnStrategies * useDraggableScroll * Markdown * Modal * ErrorFallback * Clipboard button * AxelarTransfer * ClientOnly * NavbarOsmoPrice * use-steps * NavbarOsmosisUpdates * OneClickTradingSettings * OneClickTradingIntroModal * QRCode * AvatarIcon * OneClickTradingWelcomeBack * HistoricalPriceChart * PoolComposition * IconButton * ConcentratedLiquidityDepthChart * LinkButton * OneClickTradingConnectToContinue * HistoricalPriceChartV2 * TokenDetails * FiltersModal * ErrorBoundary * SkeletonLoader * get * SEO * dayjs * Cleanup 1 * Fix QR code import * Clean up component name to match file * Remove t value * Update remove value
* Wrap test in act * Test updating act
CryptoAssassin1
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.