Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mattupham/fe 513 eslint disallow default exports #3297

Merged
merged 40 commits into from
Jun 6, 2024

Conversation

mattupham
Copy link
Contributor

@mattupham mattupham commented Jun 4, 2024

What is the purpose of the change:

  • we ran into many default import / export issues with knip when identifying unused packages
  • enforce consistency throughout the codebase, prefer matching imports / exports
Screenshot 2024-06-04 at 5 53 52 PM

Linear Task

Linear Task URL

Brief Changelog

  • enforce named exports with eslint (for next.js pages, there are ignored and defaults are used)
  • migrate default exports to named exports
  • fix paths

Copy link

vercel bot commented Jun 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
osmosis-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 6, 2024 3:49pm
4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
osmosis-frontend-datadog ⬜️ Ignored (Inspect) Visit Preview Jun 6, 2024 3:49pm
osmosis-frontend-dev ⬜️ Ignored (Inspect) Visit Preview Jun 6, 2024 3:49pm
osmosis-frontend-edgenet ⬜️ Ignored (Inspect) Jun 6, 2024 3:49pm
osmosis-testnet ⬜️ Ignored (Inspect) Visit Preview Jun 6, 2024 3:49pm

@mattupham mattupham merged commit bc19f28 into stage Jun 6, 2024
25 of 26 checks passed
@mattupham mattupham deleted the mattupham/fe-513-eslint-disallow-default-exports branch June 6, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants