-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update kado iframe integration #3282
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
WalkthroughThe Changes
Poem
Recent Review DetailsConfiguration used: CodeRabbit UI Files selected for processing (1)
Additional Context UsedBiome (3)
Additional comments not posted (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Outside diff range and nitpick comments (1)
packages/web/integrations/kado/index.tsx (1)
Line range hint
2-5
: Optimize type-only imports.- import { WalletStatus } from "@cosmos-kit/core"; - import { observer } from "mobx-react-lite"; - import { FunctionComponent } from "react"; - import { ModalBaseProps } from "~/modals"; - import { useStore } from "~/stores"; + import type { WalletStatus } from "@cosmos-kit/core"; + import type { observer } from "mobx-react-lite"; + import type { FunctionComponent } from "react"; + import type { ModalBaseProps } from "~/modals"; + import type { useStore } from "~/stores";
src={`https://app.kado.money/?onPayCurrency=USD&onPayAmount=200&onRevCurrency=OSMO&offPayCurrency=${assetKey}&offRevCurrency=USD&network=OSMOSIS&onToAddress=${account?.address}&offFromAddress=X&cryptoList=OSMO,USDC,wBTC&networkList=OSMOSIS&apiKey=67a2aaad-a2a5-4412-be40-e3a70aa7b53d&product=BUY`} | ||
width="420" | ||
height="700" | ||
allow="clipboard-write; payment; accelerometer; gyroscope; camera; geolocation; autoplay; fullscreen;" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a title
attribute to the iframe for accessibility.
+ title="Kado Integration"
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
src={`https://app.kado.money/?onPayCurrency=USD&onPayAmount=200&onRevCurrency=OSMO&offPayCurrency=${assetKey}&offRevCurrency=USD&network=OSMOSIS&onToAddress=${account?.address}&offFromAddress=X&cryptoList=OSMO,USDC,wBTC&networkList=OSMOSIS&apiKey=67a2aaad-a2a5-4412-be40-e3a70aa7b53d&product=BUY`} | |
width="420" | |
height="700" | |
allow="clipboard-write; payment; accelerometer; gyroscope; camera; geolocation; autoplay; fullscreen;" | |
src={`https://app.kado.money/?onPayCurrency=USD&onPayAmount=200&onRevCurrency=OSMO&offPayCurrency=${assetKey}&offRevCurrency=USD&network=OSMOSIS&onToAddress=${account?.address}&offFromAddress=X&cryptoList=OSMO,USDC,wBTC&networkList=OSMOSIS&apiKey=67a2aaad-a2a5-4412-be40-e3a70aa7b53d&product=BUY`} | |
width="420" | |
height="700" | |
allow="clipboard-write; payment; accelerometer; gyroscope; camera; geolocation; autoplay; fullscreen;" | |
title="Kado Integration" |
What is the purpose of the change:
Adding additional allow params and wBTC to kado iframe integration
Linear Task
Linear Task URL
Brief Changelog
Testing and Verifying
This change has been tested locally by rebuilding the website and verified content and links are expected