[Orderbook]: Orderbook rename and module refactor #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ook, rename root crate to orderbook
AlpinYukseloglu
changed the title
crnbarr93
approved these changes
Feb 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #23
What is the purpose of the change
Renames order_book usage to orderbook. Also makes root crate orderbook. Finally, also moves up the orderbook module into
srcto be consistent with redbank's architecture, which seems quite well abstracted (the internal orderbook module was a little redundant and ultimately wouldn't save too much time for future use of this orderbook code in perps anyway).Testing and Verifying
This change is a trivial rework / code cleanup without any test coverage.