Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward slashing events to the contract for processing #187

Merged
merged 10 commits into from
Sep 6, 2024

Conversation

vuong177
Copy link
Collaborator

@vuong177 vuong177 commented Aug 26, 2024

Close: #174

Forward slashing events to the contract by using StakingKeeperAdapter

Copy link

@JakeHartnell JakeHartnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment on lines +1036 to +1038
for k, v := range maccPerms {
dupMaccPerms[k] = v
}

Check warning

Code scanning / CodeQL

Iteration over map Warning

Iteration over map may be a possible source of non-determinism
Comment on lines +1046 to +1048
for acc := range GetMaccPerms() {
modAccAddrs[authtypes.NewModuleAddress(acc).String()] = true
}

Check warning

Code scanning / CodeQL

Iteration over map Warning

Iteration over map may be a possible source of non-determinism
@vuong177 vuong177 merged commit 84b50fe into main Sep 6, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Native slashing SDK / routing mechanism
3 participants