Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ghana fuel stations #9944

Merged
merged 18 commits into from
Nov 13, 2024
Merged

Add Ghana fuel stations #9944

merged 18 commits into from
Nov 13, 2024

Conversation

sammyhawkrad
Copy link
Contributor

No description provided.

@Snowysauce Snowysauce added the add brand Actionable - add a brand to the index label Sep 14, 2024
@Snowysauce
Copy link
Collaborator

Are these stations operated by the gas companies or by independent station owners/franchises? Also, regarding "old_name": "Aminaser Oil", when did the rename to Amser Oil occur?

@sammyhawkrad
Copy link
Contributor Author

Each brand added here is an independent gas company with multiple stations.

I can't really tell when the change occurred but if you look at their Facebook page the url (https://www.facebook.com/AminaserOilLtd) has the old name but it uses the new name. The profile picture also shows the logo for the new name.

The stations are branded with the new name but the operating company maintains the old name.

@Snowysauce
Copy link
Collaborator

Each brand added here is an independent gas company with multiple stations.

Yes, but are the individual stations owned and operated by the companies? If they're not, there shouldn't be preset operator tags.

@sammyhawkrad
Copy link
Contributor Author

Yes, the individual stations are owned and operated by the companies.

@Snowysauce
Copy link
Collaborator

I can't really tell when the change occurred but if you look at their Facebook page the url (https://www.facebook.com/AminaserOilLtd) has the old name but it uses the new name. The profile picture also shows the logo for the new name.

The stations are branded with the new name but the operating company maintains the old name.

Unless the name change was fairly recent, the old_name tag is unnecessary. Since the proposed entry has the old name as a match name, iD and other editors will still search for the old name when browsing presets.

The Wikidata ID in the operator:wikidata field for this brand also points to an unrelated page.

@sammyhawkrad
Copy link
Contributor Author

The Wikidata ID in the operator:wikidata field for this brand also points to an unrelated page.

Thanks for catching that.

the old_name tag is unnecessary

The match name will be used by the editors but the old name will be useful for OSM end users. There have been discussions about old_name and it was deemed acceptable in NSI.

@Snowysauce
Copy link
Collaborator

The match name will be used by the editors but the old name will be useful for OSM end users. There have been discussions about old_name and it was deemed acceptable in NSI.

I'm aware of the referenced discussion; it was deemed acceptable on a short-term basis for recent renames. An even more recent discussion rejected a proposed use of old_name because the name change happened several years prior.

@sammyhawkrad
Copy link
Contributor Author

Alright no problem, I will remove the old name here and add them directly in OSM.

@Snowysauce Snowysauce added the needs discussion Waiting for other contributors to voice their opinion label Sep 28, 2024
@Snowysauce
Copy link
Collaborator

I would recommend dropping the operator tags per #10131 (comment). If those tags were not present, I (and possibly others) would have merged this PR weeks ago.

@Snowysauce Snowysauce merged commit df73297 into osmlab:main Nov 13, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add brand Actionable - add a brand to the index needs discussion Waiting for other contributors to voice their opinion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants