Don't limit display size for tiles stored as SQLite DB #21316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chumva
reviewed
Nov 12, 2024
| @@ -104,8 +104,7 @@ private void addLiveItem(@NonNull LocalCategory category, @NonNull File file, @N | |||
| } | |||
|
|
|||
| private void addSeparatelyCalculationItemIfNeeded(@NonNull LocalItem item) { | |||
| LocalItemType type = item.getType(); | |||
| Long limit = rules.getCalculationSizeLimit(type); | |||
| Long limit = rules.getCalculationSizeLimit(item); | |||
| if (limit != null && !separateSizeCalculationItems.contains(item)) { | |||
There was a problem hiding this comment.
Will this work if we return limit or -1?
Chumva
reviewed
Nov 12, 2024
| if (localItem.getType() == TILES_DATA) { | ||
| File file = localItem.getFile(); | ||
| boolean isSQLite = file.getName().endsWith(IndexConstants.SQLITE_EXT); | ||
| return !isSQLite ? TILES_SIZE_CALCULATION_LIMIT : -1; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This request has to fix problem described here: #21252 (comment)
The problem comes from the new conditions we set to calculate the size of the tiles (Issue: #20974), however we shouldn't set these limits for tiles those are stored as one SQLite file, because there is only one file and it calculates anyway.