Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix issues pointed by the linter #10

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

investor-uyah
Copy link
Contributor

…lved

Draft Pull Request to check for test issues

How to test these changes

  • ...

Pull Request checklists

This PR is a:

  • bug-fix
  • new feature
  • maintenance

About this PR:

  • it includes tests.
  • the tests are executed on CI.
  • the tests generate log file(s) (path).
  • pre-commit hooks were executed locally.
  • this PR requires a project documentation update.

Author's checklist:

  • I have reviewed the changes and it contains no misspelling.
  • The code is well commented, especially in the parts that contain more
    complexity.
  • New and old tests passed locally.

Additional information

Reviewer's checklist

Copy and paste this template for your review's note:

## Reviewer's Checklist

- [ ] I managed to reproduce the problem locally from the `main` branch
- [ ] I managed to test the new changes locally
- [ ] I confirm that the issues mentioned were fixed/resolved

@xmnlab xmnlab marked this pull request as ready for review June 6, 2024 00:24
@xmnlab xmnlab changed the title Issues which the linter was pointing to in the codebase has been reso… chore: Fix issues pointed by the linter Jun 6, 2024
@xmnlab xmnlab merged commit cf688e6 into osl-incubator:main Jun 6, 2024
6 checks passed
@xmnlab
Copy link
Member

xmnlab commented Jun 6, 2024

thanks @investor-uyah

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants