Skip to content

Commit

Permalink
Remove storybook for now as it doesnt work properly with other depend…
Browse files Browse the repository at this point in the history
…ency updates
  • Loading branch information
ZakarFin committed Sep 3, 2024
1 parent 57438fd commit 958db85
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
5 changes: 5 additions & 0 deletions .storybook/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
This config is for `"@storybook/react": "6.3.7"` but after other dependency updates, running storybook no longer works properly. Newer version of storybook uses webpack 5 while we are still using webpack 4.

When we have time we should make it work and generate a gallery to show available UI components on oskari.org.

As for now, since it doesn't work currently, it's easier to just remove the dependency as it flags vulnerable dependencies even when its not used.
1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@
"@babel/preset-react": "7.24.7",
"@babel/runtime-corejs3": "7.25.0",
"@cesium/engine": "10.1.0",
"@storybook/react": "6.3.7",
"@testing-library/jest-dom": "5.7.0",
"@testing-library/react": "12.1.5",
"@testing-library/user-event": "14.4.3",
Expand Down

0 comments on commit 958db85

Please sign in to comment.