Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Ansible-lint issues without rule var-naming[no-role-prefix] on skip_list #574

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Fix Ansible-lint issues without rule var-naming[no-role-prefix] on skip_list #574

wants to merge 14 commits into from

Conversation

sbstnnmnn
Copy link
Contributor

@sbstnnmnn sbstnnmnn commented Jan 25, 2024 •
edited
Loading

@sbstnnmnn sbstnnmnn force-pushed the test_ansible-lint-6.22.2 branch 3 times, most recently from 970b605 to 25e40ee Compare January 25, 2024 13:59
@sbstnnmnn sbstnnmnn changed the title Test new Asible linter Test ansible-lint-6.22.2 without rule var-naming[no-role-prefix] on skip_list Jan 25, 2024
@sbstnnmnn sbstnnmnn force-pushed the test_ansible-lint-6.22.2 branch 13 times, most recently from 805ec61 to f2c325a Compare January 29, 2024 11:33
@sbstnnmnn sbstnnmnn changed the title Test ansible-lint-6.22.2 without rule var-naming[no-role-prefix] on skip_list Fix Ansible-lint issues without rule var-naming[no-role-prefix] on skip_list Jan 29, 2024
@sbstnnmnn sbstnnmnn marked this pull request as ready for review January 29, 2024 13:55
@sbstnnmnn
Test new Asible linter
0bfe51e 
Signed-off-by: Sebastian Neumann <[email protected]>
@sbstnnmnn
Use systohc_ as a prefix in systohc role
aed8d9a 
Signed-off-by: Sebastian Neumann <[email protected]>
@sbstnnmnn
Use sshconfig_ as a prefix in ssshconfig role
e57b3ac 
Signed-off-by: Sebastian Neumann <[email protected]>
@sbstnnmnn
Use sshconfig_ as prefix of variables in ssshconfig role
fd4997b 
Signed-off-by: Sebastian Neumann <[email protected]>
@sbstnnmnn
Use sosreport_ as prefix of variables in role sosreport
503bea5 
Signed-off-by: Sebastian Neumann <[email protected]>
@sbstnnmnn
Use repository_ as prefix of variables in role repository
be1f525 
Signed-off-by: Sebastian Neumann <[email protected]>
@sbstnnmnn
Use firewall_ as prefix of variables in role firewall
37005c4 
Signed-off-by: Sebastian Neumann <[email protected]>
@sbstnnmnn
Use kernel_modules_ as prefix of variables in role kernel_modules
3db28a4 
Signed-off-by: Sebastian Neumann <[email protected]>
@sbstnnmnn sbstnnmnn force-pushed the test_ansible-lint-6.22.2 branch 2 times, most recently from 5789dc1 to d0e8b31 Compare February 1, 2024 11:41
@sbstnnmnn
Test operator role
06f713f 
Signed-off-by: Sebastian Neumann <[email protected]>
lindenb1
lindenb1 approved these changes Feb 5, 2024
View reviewed changes
Copy link
Contributor

@lindenb1 lindenb1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lindenb1 lindenb1 lindenb1 approved these changes

@berendt berendt Awaiting requested review from berendt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sbstnnmnn @lindenb1