Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove getters #86

Closed
wants to merge 3 commits into from
Closed

remove getters #86

wants to merge 3 commits into from

Conversation

osiegmar
Copy link
Owner

** Please create PR against the develop branch **

This PR relates to Issue: #

Proposed Changes

Performance

In order to prevent a performance degradation please run a benchmark
using ./gradlew jmh before and after your change and show the results.

@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (831047e) 100.00% compared to head (ac1ed67) 100.00%.
Report is 18 commits behind head on develop.

❗ Current head ac1ed67 differs from pull request most recent head f4d71fb. Consider uploading reports for the commit f4d71fb to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##             develop       #86    +/-   ##
============================================
  Coverage     100.00%   100.00%            
- Complexity       194       296   +102     
============================================
  Files             13        21     +8     
  Lines            653       942   +289     
  Branches          95       128    +33     
============================================
+ Hits             653       942   +289     
Files Coverage Δ
...a/de/siegmar/fastcsv/reader/ByteChannelStream.java 100.00% <100.00%> (ø)
...egmar/fastcsv/reader/CollectingStatusListener.java 100.00% <100.00%> (ø)
.../main/java/de/siegmar/fastcsv/reader/CsvIndex.java 100.00% <100.00%> (ø)
...main/java/de/siegmar/fastcsv/reader/CsvReader.java 100.00% <100.00%> (ø)
...main/java/de/siegmar/fastcsv/reader/CsvRecord.java 100.00% <100.00%> (ø)
...e/siegmar/fastcsv/reader/CsvRecordSpliterator.java 100.00% <100.00%> (ø)
...ain/java/de/siegmar/fastcsv/reader/CsvScanner.java 100.00% <100.00%> (ø)
...va/de/siegmar/fastcsv/reader/IndexedCsvReader.java 100.00% <100.00%> (ø)
...java/de/siegmar/fastcsv/reader/NamedCsvReader.java 100.00% <100.00%> (ø)
...java/de/siegmar/fastcsv/reader/NamedCsvRecord.java 100.00% <100.00%> (ø)
... and 7 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@osiegmar osiegmar force-pushed the develop branch 2 times, most recently from 39412e0 to d30725b Compare August 23, 2023 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant