-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added theta12 as to extract_param #51
Open
chadhenshaw
wants to merge
13
commits into
oshaughn:master
Choose a base branch
from
chadhenshaw:Henshaw_precession
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When one of the spins is non-zero but very small (e-06) calculating chi_pavg throws a divide by zero error. In this limit chi_pavg = chi_p, so now this is calculated instead.
This is done to eliminate calculation error during PE instead of when using plot_posterior_corner
This was done to eliminate calculation error during PE instead of while plotting
Updated calculation criteria for chi_pavg. Also includes changes to faciliate usage of chi_pavg in CIP.
Updates to allow usage of chi_pavg as parameter-implied.
reverting due to weirdness
Updated to include chi_pavg as parameter-implied.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shouldn't change anything else, just added theta12 as a viable parameter to extract. Tested locally without any issues.