Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inserting diffusion-code in EPG #4

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

inserting diffusion-code in EPG #4

wants to merge 7 commits into from

Conversation

mfuderer
Copy link
Collaborator

Next to pulses, relaxation, inversion and regrowth, we can model the effect of diffusion

@oscarvanderheide
Copy link
Owner

Nice. Before merging, I have some questions/requests.

  1. Would it make sense to rename D to ADC?

  2. Please add tests (in test/runtests.jl) that at least check:

    • When the diffusion coefficient is zero, that the simulation results are the same as if there was no diffusion coefficient in the parameters

    • When the simulations with diffusion effects run on both cpu and gpu, that give the same (in an \approx sense) results.

  3. Also in src/interfaces/tissueproperties.jl, new variants of lines like const T1T2 = T₁T₂ can be added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants